fixes after merge

ydb-platform · Dec 15, 2023 · 46ef8e8 · 46ef8e8
1 parent c4a7fc7
commit 46ef8e8
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -9,6 +9,7 @@ on:
 jobs:
   autoformatter:
     strategy:
+      fail-fast: false
       matrix:
         source-dir: ["./src/", "./examples/src/", "./slo/src/"]
         include:
@@ -38,6 +39,7 @@ jobs:
 
   inspection:
     strategy:
+      fail-fast: false
       matrix:
         solutionPath: ["./src/YdbSdk.sln", "./examples/src/YdbExamples.sln", "./slo/src/src.sln"]
     runs-on: ubuntu-latest

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -8,6 +8,7 @@ on:
 jobs:
   unit-tests:
     strategy:
+      fail-fast: false
       matrix:
         os: [ubuntu-22.04, windows-2022, macos-12]
         dotnet-version: [6.0.x, 7.0.x]

diff --git a/examples/src/Common/DataUtils.cs b/examples/src/Common/DataUtils.cs
@@ -7,7 +7,7 @@ namespace Ydb.Sdk.Examples;
 
 public record Series(ulong SeriesId, string Title, DateTime ReleaseDate, string Info)
 {
-    public static Series FromRow(Sdk.Value.ResultSet.Row row)
+    public static Series FromRow(Value.ResultSet.Row row)
     {
         return new Series(
             SeriesId: (ulong)row["series_id"].GetOptionalUint64()!,

diff --git a/slo/src/Client.cs b/slo/src/Client.cs
@@ -2,6 +2,7 @@
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Logging.Abstractions;
 using Ydb.Sdk;
+using Ydb.Sdk.Services.Sessions;
 using Ydb.Sdk.Services.Table;
 
 namespace slo;

diff --git a/src/Ydb.Sdk/src/Services/Sessions/SessionPoolBase.cs b/src/Ydb.Sdk/src/Services/Sessions/SessionPoolBase.cs
@@ -191,6 +191,7 @@ private void Dispose(bool disposing)
                     var task = DeleteSession(state.Session.Id);
                     tasks[i++] = task;
                 }
+
                 Task.WaitAll(tasks);
             }
 

diff --git a/src/Ydb.Sdk/src/Services/Table/ExecuteDataQuery.cs b/src/Ydb.Sdk/src/Services/Table/ExecuteDataQuery.cs
@@ -96,7 +96,7 @@ public async Task<ExecuteDataQueryResponse> ExecuteDataQuery(
                     ? TransactionState.Active
                     : TransactionState.Void;
 
-                tx = Transaction.FromProto(resultProto.TxMeta, _logger);
+                tx = Transaction.FromProto(resultProto.TxMeta, Logger);
             }
 
             ExecuteDataQueryResponse.ResultData? result = null;