Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#41 Replace TMaybe to std::optional after update #81

Merged
merged 7 commits into from
Mar 6, 2024
Merged

#41 Replace TMaybe to std::optional after update #81

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
792cce2
replacement: ydb_scripting.*; build=succeed
antonporodnikov Mar 4, 2024
b8055f5
replacement: *.*; build=succeed
antonporodnikov Mar 4, 2024
eb0c555
delete maybe files, clear dependencies; build=succeed
antonporodnikov Mar 5, 2024
d8a3dea
corrections after first review by GitSparTV
antonporodnikov Mar 6, 2024
c2a8e80
ydb_topic/impl/write_session_impl.cpp fix
antonporodnikov Mar 6, 2024
9cca962
write_session_impl.* fix
antonporodnikov Mar 6, 2024
84f76f6
corrections after Gazizonoki review
antonporodnikov Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/ydb_persqueue_core/impl/write_session_impl.cpp
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поменяй на value_or

Copy link
Contributor Author

@antonporodnikov antonporodnikov Mar 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправил.

Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ NThreading::TFuture<void> TWriteSessionImpl::WaitEvent() {
void TWriteSessionImpl::WriteInternal(
TContinuationToken&&, std::string_view data, std::optional<ECodec> codec, ui32 originalSize, std::optional<ui64> seqNo, std::optional<TInstant> createTimestamp
) {
TInstant createdAtValue = message.CreateTimestamp_.has_value() ? *message.CreateTimestamp_ : TInstant::Now();
TInstant createdAtValue = createTimestamp.has_value() ? *createTimestamp : TInstant::Now();
bool readyToAccept = false;
size_t bufferSize = data.size();
with_lock(Lock) {
Expand Down
Loading