Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge to stable-23-3 #314

Merged
merged 2 commits into from
Feb 1, 2024
Merged

merge to stable-23-3 #314

merged 2 commits into from
Feb 1, 2024

Conversation

qkrorlqr
Copy link
Collaborator

@qkrorlqr qkrorlqr commented Feb 1, 2024

No description provided.

@qkrorlqr
loadtest env tear_down should happen inside finally blocks because ot…
f9c7797 
…herwise we may get an exception because blockstore-loadtest run failed and will never know that kikimr daemon crashed (#290)
@qkrorlqr
issue #95 NBSNEBIUS-70: if Flush/Compaction/Cleanup/FlushBytes ops ar…
a8c4716 
…e enqueued before CompactionMap is completely loaded, their EOperationStates should not get stuck in the Enqueued state (#303)
@qkrorlqr
Copy link
Collaborator Author

qkrorlqr commented Feb 1, 2024

100% tests passed, 0 tests failed out of 1503

тесты прошли, а вот генерация таблички с результатами свалилась:
Run if [ -f "${ARTIFACTS_DIR}/junit.xml" ]; then

  • '[' -f /actions-runner/_work/nbs/nbs/tmp_build/artifacts/junit.xml ']'
  • '[' -f /actions-runner/_work/nbs/nbs/tmp_build/artifacts/junit_rerun.xml ']'
  • .github/scripts/tests/generate-summary.py --summary-out-path /summary --summary-url-prefix https://storage.ai.nebius.cloud/github-actions-s3/ydb-platform/nbs/PR-check-using-cmake/7741043489/1/nebius-x86-64/summary/ CTest ctest.html /actions-runner/_work/nbs/nbs/tmp_build/artifacts/junit.xml
    Traceback (most recent call last):
    File "/actions-runner/_work/nbs/nbs/.github/scripts/tests/generate-summary.py", line 419, in
    main()
    File "/actions-runner/_work/nbs/nbs/.github/scripts/tests/generate-summary.py", line 406, in main
    gh = Github(auth=GithubAuth.Token(os.environ["GITHUB_TOKEN"]))
    File "/usr/lib/python3.10/os.py", line 680, in getitem
    raise KeyError(key) from None
    KeyError: 'GITHUB_TOKEN'

@qkrorlqr qkrorlqr merged commit 3e3896f into stable-23-3 Feb 1, 2024
4 of 5 checks passed
@qkrorlqr qkrorlqr deleted the users/qkrorlqr/stable-23-3 branch February 1, 2024 12:57
@budevg budevg mentioned this pull request Apr 3, 2024
Merged
@dvrazumov dvrazumov mentioned this pull request Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yegorskii yegorskii yegorskii approved these changes

@debnatkh debnatkh debnatkh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qkrorlqr @debnatkh @yegorskii