Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NBS-5217: Allow images from different folders in tests #2413

Merged
merged 3 commits into from
Nov 6, 2024
Merged

NBS-5217: Allow images from different folders in tests #2413

merged 3 commits into from
Nov 6, 2024

Conversation

ya-ksgamora
Copy link
Collaborator

@ya-ksgamora ya-ksgamora commented Nov 2, 2024 •
edited
Loading

There's a need to use images from different folders in tests

Added ability to use images from different folders

To achieve this:

  • Added image_folder_id arg to _resolve_image_name function in ycp wrapper
  • Added image_folder_id to FolderDesc class
  • Added image_folder_id to corresponding test configs
  • Added --image-folder-id flag to test runners
  • Canonized corresponding tests

@ya-ksgamora ya-ksgamora self-assigned this Nov 2, 2024
@ya-ksgamora ya-ksgamora added CI Fixes/improvements of the github CI and our local CI scripts minor_improvement A small non-critical feature labels Nov 2, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit d98302d.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6076 6076 0 0 0 0

@ya-ksgamora ya-ksgamora merged commit 3470906 into main Nov 6, 2024
11 of 12 checks passed
@ya-ksgamora ya-ksgamora deleted the users/ya-ksgamora/NBS-5217 branch November 6, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komarevtsev-d komarevtsev-d komarevtsev-d approved these changes

@debnatkh debnatkh debnatkh approved these changes

Assignees

@ya-ksgamora ya-ksgamora

Labels
CI Fixes/improvements of the github CI and our local CI scripts minor_improvement A small non-critical feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ya-ksgamora @debnatkh @komarevtsev-d