Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filestore] issue-2190: support reconnect for local file system #2103

Merged
merged 5 commits into from
Oct 22, 2024
Merged

[Filestore] issue-2190: support reconnect for local file system #2103

merged 5 commits into from
Oct 22, 2024

Conversation

budevg
Copy link
Collaborator

@budevg budevg commented Sep 23, 2024 •
edited by qkrorlqr
Loading

@budevg budevg changed the title users/evgenybud/filestore local reconnect [Filestore] avoid fsync on every write for local service Sep 23, 2024
@budevg budevg changed the base branch from main to users/evgenybud/filestore-local-fsync September 23, 2024 07:39
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 33c1bc9.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5828 5827 0 1 0 0

@budevg budevg changed the title [Filestore] avoid fsync on every write for local service [Filestore] support reconnect for local file system Sep 23, 2024
@budevg budevg added large-tests Launch large tests for PR filestore Add this label to run only cloud/filestore build and tests on PR asan Launch builds with address sanitizer along with regular build tsan Launch builds with thread sanitizer along with regular build labels Sep 24, 2024
Base automatically changed from users/evgenybud/filestore-local-fsync to main September 24, 2024 14:58
@budevg budevg force-pushed the users/evgenybud/filestore-local-reconnect branch from 33c1bc9 to ffac955 Compare September 25, 2024 08:35
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit ffac955.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1876 1876 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit ffac955.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1876 1876 0 0 0 0

🟢 linux-x86_64-release-asan: all tests PASSED for commit ffac955.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1862 1862 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit ffac955.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1876 1876 0 0 0 0

🟢 linux-x86_64-release-asan: all tests PASSED for commit ffac955.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1862 1862 0 0 0 0

🟢 linux-x86_64-release-tsan: all tests PASSED for commit ffac955.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1852 1852 0 0 0 0

qkrorlqr
qkrorlqr reviewed Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@qkrorlqr qkrorlqr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужна ссылка на issue через #issue-no в description

cloud/filestore/config/server.proto Outdated Show resolved Hide resolved
cloud/filestore/libs/service_local/fs_data.cpp Show resolved Hide resolved
cloud/filestore/libs/service_local/fs_data.cpp Outdated Show resolved Hide resolved
cloud/filestore/libs/service_local/fs_node.cpp Show resolved Hide resolved
cloud/filestore/libs/service_local/fs_session.cpp Outdated Show resolved Hide resolved
cloud/storage/core/libs/common/persistent_table.h Outdated Show resolved Hide resolved
cloud/storage/core/libs/common/persistent_table.h Outdated Show resolved Hide resolved
cloud/storage/core/libs/common/persistent_table.h Outdated Show resolved Hide resolved
cloud/storage/core/libs/common/persistent_table.h Outdated Show resolved Hide resolved
cloud/storage/core/libs/common/persistent_table.h Outdated Show resolved Hide resolved
@budevg budevg added asan Launch builds with address sanitizer along with regular build and removed asan Launch builds with address sanitizer along with regular build labels Oct 1, 2024
@budevg budevg changed the title [Filestore] support reconnect for local file system [Filestore] issue-2190: support reconnect for local file system Oct 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit ffac955.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1876 1876 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit ffac955.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1876 1876 0 0 0 0

🟢 linux-x86_64-release-asan: all tests PASSED for commit ffac955.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1862 1862 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit ffac955.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1876 1876 0 0 0 0

🟢 linux-x86_64-release-asan: all tests PASSED for commit ffac955.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1862 1862 0 0 0 0

🟢 linux-x86_64-release-tsan: all tests PASSED for commit ffac955.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1852 1852 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 2b7c72c.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1879 1878 0 1 0 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 2b7c72c.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1879 1878 0 1 0 0

🔴 linux-x86_64-release-asan: some tests FAILED for commit 2b7c72c.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1865 1864 0 1 0 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 2b7c72c.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1879 1878 0 1 0 0

🔴 linux-x86_64-release-asan: some tests FAILED for commit 2b7c72c.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1865 1864 0 1 0 0

🔴 linux-x86_64-release-tsan: some tests FAILED for commit 2b7c72c.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1855 1853 0 2 0 0

@budevg budevg force-pushed the users/evgenybud/filestore-local-reconnect branch from 2b7c72c to 20caee1 Compare October 8, 2024 18:56
@budevg budevg requested a review from qkrorlqr October 8, 2024 18:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 20caee1.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1904 1904 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 20caee1.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1904 1904 0 0 0 0

🔴 linux-x86_64-release-asan: some tests FAILED for commit 20caee1.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1890 1889 0 1 0 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 20caee1.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1904 1904 0 0 0 0

🔴 linux-x86_64-release-asan: some tests FAILED for commit 20caee1.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1890 1889 0 1 0 0

🔴 linux-x86_64-release-tsan: some tests FAILED for commit 20caee1.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1881 1876 0 2 3 0

@budevg budevg force-pushed the users/evgenybud/filestore-local-reconnect branch from 20caee1 to 2e6c56e Compare October 9, 2024 08:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 33c964a.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1904 1904 0 0 0 0

🟢 linux-x86_64-release-asan: all tests PASSED for commit 33c964a.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1890 1890 0 0 0 0

🔴 linux-x86_64-release-tsan: some tests FAILED for commit 33c964a.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1881 1876 0 2 3 0

@qkrorlqr qkrorlqr mentioned this pull request Oct 10, 2024
Closed
qkrorlqr
qkrorlqr reviewed Oct 14, 2024
View reviewed changes
cloud/filestore/config/server.proto Outdated Show resolved Hide resolved
cloud/filestore/libs/service_local/fs_node.cpp Show resolved Hide resolved
cloud/filestore/libs/service_local/fs_session.cpp Show resolved Hide resolved
cloud/filestore/libs/service_local/index.h Outdated Show resolved Hide resolved
cloud/filestore/libs/service_local/index.h Show resolved Hide resolved
cloud/filestore/libs/service_local/session.h Outdated Show resolved Hide resolved
cloud/filestore/libs/service_local/session.h Show resolved Hide resolved
cloud/filestore/libs/service_local/session.h Outdated Show resolved Hide resolved
cloud/filestore/libs/service_local/session.h Outdated Show resolved Hide resolved
cloud/filestore/libs/service_local/session.h Outdated Show resolved Hide resolved
@budevg budevg requested a review from qkrorlqr October 16, 2024 06:52
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 6d805f1.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1904 1904 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 6d805f1.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1904 1904 0 0 0 0

🟢 linux-x86_64-release-asan: all tests PASSED for commit 6d805f1.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1890 1890 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit b1bd501.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1904 1904 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit b1bd501.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1904 1904 0 0 0 0

🟢 linux-x86_64-release-asan: all tests PASSED for commit b1bd501.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1890 1890 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit b1bd501.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1904 1904 0 0 0 0

🟢 linux-x86_64-release-asan: all tests PASSED for commit b1bd501.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1890 1890 0 0 0 0

🟢 linux-x86_64-release-tsan: all tests PASSED for commit b1bd501.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1880 1880 0 0 0 0

@budevg budevg force-pushed the users/evgenybud/filestore-local-reconnect branch from b1bd501 to d4f5cd0 Compare October 21, 2024 15:24
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit d4f5cd0.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1916 1916 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit d4f5cd0.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1916 1916 0 0 0 0

🟢 linux-x86_64-release-asan: all tests PASSED for commit d4f5cd0.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1902 1902 0 0 0 0

qkrorlqr
qkrorlqr reviewed Oct 21, 2024
View reviewed changes
cloud/filestore/libs/service_local/index.h Outdated Show resolved Hide resolved
cloud/filestore/libs/service_local/index.h Outdated Show resolved Hide resolved
cloud/filestore/libs/service_local/index.h Outdated Show resolved Hide resolved
cloud/filestore/libs/service_local/index.h Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit d4f5cd0.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1916 1916 0 0 0 0

🟢 linux-x86_64-release-asan: all tests PASSED for commit d4f5cd0.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1902 1902 0 0 0 0

🟢 linux-x86_64-release-tsan: all tests PASSED for commit d4f5cd0.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1892 1892 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit c378427.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1916 1916 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit c378427.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1916 1916 0 0 0 0

🟢 linux-x86_64-release-asan: all tests PASSED for commit c378427.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1902 1902 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit c378427.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1916 1916 0 0 0 0

🟢 linux-x86_64-release-asan: all tests PASSED for commit c378427.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1902 1902 0 0 0 0

🟢 linux-x86_64-release-tsan: all tests PASSED for commit c378427.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1892 1892 0 0 0 0

@budevg budevg merged commit aea322d into main Oct 22, 2024
17 of 18 checks passed
@budevg budevg deleted the users/evgenybud/filestore-local-reconnect branch October 22, 2024 10:33
budevg added a commit that referenced this pull request Oct 24, 2024
@budevg
[Filestore] issue-2190: support reconnect for local file system (#2103)
f852012
@budevg budevg mentioned this pull request Oct 24, 2024
Merged
budevg added a commit that referenced this pull request Oct 25, 2024
@budevg
[Filestore] issue-2190: support reconnect for local file system (#2103)
f2294a7
budevg added a commit that referenced this pull request Oct 28, 2024
@budevg
[merge to stable]: issue-2190, issue-2189, issue-2263 (#2344)
3f709c6 
* issue-2190: persistent table data structure (#2199)

Implementation of records table on top of memory mapped file.

This will be used to recover inodes and file descriptors in later PRs

* issue-2263: generate nfs-vhost-local.txt config file (#2264)

* [Filestore] issue-2190: support reconnect for local file system (#2103)

* [Filestore] issue-2189: support O_DIRECT in local filestore (#2188)

* fix compilation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yegorskii yegorskii yegorskii approved these changes

@qkrorlqr qkrorlqr qkrorlqr approved these changes

Assignees
No one assigned
Labels
asan Launch builds with address sanitizer along with regular build filestore Add this label to run only cloud/filestore build and tests on PR large-tests Launch large tests for PR tsan Launch builds with thread sanitizer along with regular build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@budevg @qkrorlqr @yegorskii