issue-1922: properly tracking BlobsCount to guarantee the BlobsCount <= real blob count in range property #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…<= real blob count in range property
qkrorlqr
added
large-tests
qkrorlqr
added
the
rebase
qkrorlqr
commented
Oct 14, 2024
yegorskii
approved these changes
Oct 15, 2024
debnatkh
approved these changes
Oct 15, 2024
qkrorlqr
added a commit
that referenced
this pull request
Oct 15, 2024
…<= real blob count in range property (#2017)
debnatkh
pushed a commit
that referenced
this pull request
Oct 16, 2024
…ing, fixes in filestore-client, fix in BlobsCount accounting; minor fixes in blockstore (#2287) * fixed race: CallContext->RequestType was being modified by the code in StorageService and accessed by the code calculating MaxTime for inflight requests at the same time - we should not reuse the same CallContext for different requests, we should make separate CallContexts (#2223) * Adding a debug assert to debug the case when PostponeTsCycles is zero upon Advance() (#2212) * filestore-client findgarbage paging fix + some other improvements and cleanup (#2225) * filestore-client findgarbage paging fix * filestore-client - outputting garbage file sizes in the findgarbage command output; tablet - cleanup: MaxResponseBytes config param was unused, using it * filestore-client - outputting garbage file sizes in the findgarbage command output; tablet - cleanup: MaxResponseBytes config param was unused, using it - recanon test * decreasing ShouldHandleRangeIdCollisionsInCompactionMapStats ut iteration count under tsan (#2229) * moved ShouldHandleRangeIdCollisionsInCompactionMapStats to tablet_ut_data_stress (#2236) * moved ShouldHandleRangeIdCollisionsInCompactionMapStats to tablet_ut_data_stress * moved ShouldHandleRangeIdCollisionsInCompactionMapStats to tablet_ut_data_stress - fix * issue-1932: renamed follower to shard, reasons: 1. some of the code already calls those entities "shards" 2. "follower" implies some kind of replication and this entity is not related to replication at all (#2246) * issue-1932: renamed follower to shard, reasons: 1. some of the code already calls those entities shards 2. follower implies some kind of replication and this entity is not related to replication at all * issue-1932: renamed follower to shard, reasons: 1. some of the code already calls those entities shards 2. follower implies some kind of replication and this entity is not related to replication at all - fix build * issue-1932: renamed follower to shard, reasons: 1. some of the code already calls those entities shards 2. follower implies some kind of replication and this entity is not related to replication at all - fix canondata * issue-1932: renamed follower to shard, reasons: 1. some of the code already calls those entities shards 2. follower implies some kind of replication and this entity is not related to replication at all - fix canondata * moved heavy uts ShouldTruncateLargeFiles and ShouldTruncateLargeFiles128_KB to tablet_ut_data_stress.cpp (#2252) * issue-1928: filestore-client: using ISession instead of IClient for the Session-aware methods to properly process E_FS_INVALID_SESSION errors; existing tests are more or less sufficient to ensure that this code is correct (#2265) * issue-2033: sending ResetSession requests to shards upon ResetSession to leader (in the same way it's done for Create/DestroySession); extracted common code for this thing from Create/DestroySession (#2266) * issue-2033: sending ResetSession requests to shards upon ResetSession to leader (in the same way it's done for Create/DestroySession); extracted common code for this thing from Create/DestroySession * issue-2033: fixed logging * issue-2033: better * issue-2033: cleanup * deleting explicit ActivityType setting - 1. it's broken 2. the default value is better anyway (#2276) * issue-1922: properly tracking BlobsCount to guarantee the BlobsCount <= real blob count in range property (#2017) * updated CMakeLists.txt * fixed build for old clang * deleted excess ut (accidentally added during conflict resolution)
WilyTiger
pushed a commit
that referenced
this pull request
Oct 16, 2024
…<= real blob count in range property (#2017)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1922