Always respond with E_REJECT when killing a volume tablet actor #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drbasic
force-pushed
the
users/drbasic/save-all-partition-requests
branch
from
b7d8ab2
to
757227e
Compare
drbasic
added
large-tests
drbasic
force-pushed
the
users/drbasic/save-all-partition-requests
branch
2 times, most recently
from
4be0511
to
f3b10ca
Compare
drbasic
changed the title
drbasic
commented
Sep 19, 2024
drbasic
force-pushed
the
users/drbasic/save-all-partition-requests
branch
from
f3b10ca
to
b21ae83
Compare
|
Note This is an automated comment that will be appended during run. 🟢 linux-x86_64-release-asan: all tests PASSED for commit b21ae83.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit b21ae83.
|
qkrorlqr
reviewed
Oct 18, 2024
komarevtsev-d
approved these changes
Oct 21, 2024
|
Note This is an automated comment that will be appended during run. 🟢 linux-x86_64-release-asan: all tests PASSED for commit 709483d.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 709483d.
|
qkrorlqr
approved these changes
Oct 21, 2024
drbasic
added a commit
that referenced
this pull request
Oct 24, 2024
* Save all partition requests info in VolumeRequests * Test * Fix review issues * Small improvements
drbasic
added a commit
that referenced
this pull request
Oct 25, 2024
* Save all partition requests info in VolumeRequests * Test * Fix review issues * Small improvements
drbasic
added a commit
that referenced
this pull request
Oct 25, 2024
* Replace TString methods Data() -> data(), Size() -> size(), Empty() -> empty() (#2324) * Always respond with E_REJECT when killing a volume tablet actor (#1988) * Save all partition requests info in VolumeRequests * Test * Fix review issues * Small improvements * :Qget rid of some arcadia string functions (#2257) * get rid of some arcadia string functions * update * Fix TString methods (#2343) --------- Co-authored-by: yegorskii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Раньше не всегда запросы, которые отправлялись в партишен, сохранялись в акторе вольюма в векторе VolumeRequests. Это работало только если паришен был один, и не происходило отслеживание записанных блоков.
Сейчас сохранение происходит во всех случаях. А значит, если таблетка вольюма умирает, то и E_REJECTED будет отправляться всегда https://github.com/ydb-platform/nbs/blob/main/cloud/blockstore/libs/storage/volume/volume_actor.cpp#L531
Поведение стало консистентным.