Direct comparison can fail for wrapped errors, use errors.Is(err, target) instead.

Signed-off-by: Anton Kuchin <[email protected]>

This way it is more obvious that they are unused and makes the linter happy.

Signed-off-by: Anton Kuchin <[email protected]>

This is an impossible code path now but someday this can change and
otherwise function is ready to have nil mnt, so fix one more condition.

Signed-off-by: Anton Kuchin <[email protected]>

Signed-off-by: Anton Kuchin <[email protected]>

Some errors are expected or don't matter, so ignore them explicitly.

Signed-off-by: Anton Kuchin <[email protected]>

Signed-off-by: Anton Kuchin <[email protected]>

This will be required later to add staged mount for vhost endpoints

Signed-off-by: Anton Kuchin <[email protected]>

Volume context and capabilities should be reused in Stage and Publish
Move most of other constants from arguments to variables.

Signed-off-by: Anton Kuchin <[email protected]>

This will be used later when part of NodePublish logic for vhost
endpoints will be moved to NodeStage.

Signed-off-by: Anton Kuchin <[email protected]>

Before we assumed that pod ID is always present and can be used as a
part of mount path, but if endpoint is started in NodePublish podId is
not known. For such cases return staging directory name where endpoint
will be started.

Signed-off-by: Anton Kuchin <[email protected]>

…anceId attribute

Signed-off-by: Anton Kuchin <[email protected]>

Also rename all socketDir variables to endpointDir for conststency.

Signed-off-by: Anton Kuchin <[email protected]>

In most callsites we already know endpointDir, so just accept it as an
argument instead of rebuilding every time.

Signed-off-by: Anton Kuchin <[email protected]>

This keeps apart codepaths that require podId separate from ones that rely on
instanceID.
It also allows to remove temporary hack from getInstanceOrPodId and rename
it back to getPodId.

Signed-off-by: Anton Kuchin <[email protected]>

This way instanceId variable can be used only if it is not empty and
error handling happens only if any of stage functions was called.

Signed-off-by: Anton Kuchin <[email protected]>

We will need these parameters later to properly stop endpoints during
NodeUnstage. This also allows to skip unnecessary calls in unstage of
old volumes.

Signed-off-by: Anton Kuchin <[email protected]>

We had all staged disk on the node to be in shared staging directory,
but now we have all necessary information in stage record to get
instanceId in NodeUnstage so we can group disks in instance directory.

Old path looked like:
/...NBS.../sockets/${POD_ID}/${VOLUME_ID}/[nbs,nfs].sock

Intermediate path looked like:
/...NBS.../sockets/staging/${VOLUME_ID}/[nbs,nfs].sock

New path will look like:
/...NBS.../sockets/${INSTANCE_ID}/${VOLUME_ID}/[nbs,nfs].sock

Signed-off-by: Anton Kuchin <[email protected]>

According to spec target directory must be removed after NodeUnstage
but now mounter mock doesn't delete it during mount point cleanup.
If directory deletion is enabled then other test breaks because it
relies on previous tests leaving temoprary directories.

This will be fixed separately form this PR.

Signed-off-by: Anton Kuchin <[email protected]>

We use the same code for all types of volumes in NodeUnpublish because
we have no good way to get their type.
Add comment to explain why StopEndpoint calls in NodeUnpublishVolume has no
effect for staged disks.

Signed-off-by: Anton Kuchin <[email protected]>