Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Disk Manager]: Move hanging tasks metric to collect lister metrics #1916

Merged
merged 84 commits into from
Sep 10, 2024
Merged

[Disk Manager]: Move hanging tasks metric to collect lister metrics #1916

merged 84 commits into from
Sep 10, 2024

Conversation

jkuradobery
Copy link
Collaborator

@jkuradobery jkuradobery commented Aug 30, 2024 •
edited
Loading

#903
Move hanging tasks metric evaluation to collect lister metric.
Collect traceback according to new hanging tasks definition. (If tasks 2 times over the estimate, or working longer than one hour if no estimate).

@jkuradobery jkuradobery changed the title Users/jkuradobery/report task id for hanging tasks [Disk Manager]: Move hanging tasks metric to collect lister metrics Aug 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit cdddefc.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5701 5701 0 0 0 0

@jkuradobery jkuradobery added ok-to-test Label to approve test launch for external members large-tests Launch large tests for PR disk_manager Add this label to run only cloud/disk_manager build and tests on PR labels Sep 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 1f03d61.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
830 830 0 0 0 0

@jkuradobery
Inline setupExpectationsForHangingTasksMetricsTest
7ca89ca 
Wait for the first metric to appear in TestHangingTasksMetrics
SvartMetal
SvartMetal previously approved these changes Sep 9, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 22631b8.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
830 830 0 0 0 0

BarkovBG
BarkovBG reviewed Sep 9, 2024
View reviewed changes
cloud/tasks/storage/storage_ydb_impl.go Show resolved Hide resolved
cloud/tasks/storage/storage_ydb_test.go Outdated Show resolved Hide resolved
cloud/tasks/storage/storage_ydb_test.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 5e0026d.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
830 830 0 0 0 0

@jkuradobery jkuradobery merged commit f8fa126 into main Sep 10, 2024
11 of 16 checks passed
@jkuradobery jkuradobery deleted the users/jkuradobery/report-task-id-for-hanging-tasks branch September 10, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BarkovBG BarkovBG BarkovBG approved these changes

@SvartMetal SvartMetal SvartMetal approved these changes

Assignees
No one assigned
Labels
disk_manager Add this label to run only cloud/disk_manager build and tests on PR large-tests Launch large tests for PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkuradobery @SvartMetal @BarkovBG