Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-1657: resize pvc with nbsd-lightweight and minikube #1846

Merged
merged 11 commits into from
Sep 26, 2024
Merged

issue-1657: resize pvc with nbsd-lightweight and minikube #1846

merged 11 commits into from
Sep 26, 2024

Conversation

antonmyagkov
Copy link
Collaborator

@antonmyagkov antonmyagkov commented Aug 22, 2024 •
edited by SvartMetal
Loading

issue: #1657

Support pvc resize with minikube/nbsd-lightweight

  1. Update minikube manifests:
  • Add csi-resizer sidecar to csi controller
  • Allow to expand volume
  • Increase pvc storage limit as it is not possible to expand volume beyond the limit
  1. Fix volume resize in nbsd-lightweight. Old blocks count value was cached in several places: mounted volume, storage and storage adapter. Fixed by recreating storage/storage adapter.

@antonmyagkov antonmyagkov force-pushed the users/myagkov/issue-1657-csi-resizer branch from f0f65ea to d81b727 Compare August 22, 2024 18:04
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit d81b727.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5687 5684 0 0 1 2

@antonmyagkov antonmyagkov force-pushed the users/myagkov/issue-1657-csi-resizer branch from d81b727 to 177bf05 Compare September 14, 2024 09:16
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 177bf05.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5772 5771 0 1 0 0

@antonmyagkov antonmyagkov force-pushed the users/myagkov/issue-1657-csi-resizer branch from 177bf05 to 6a03597 Compare September 16, 2024 08:06
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 6a03597.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5773 5769 0 0 2 2

@antonmyagkov antonmyagkov force-pushed the users/myagkov/issue-1657-csi-resizer branch from 6a03597 to 75def04 Compare September 16, 2024 12:46
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 75def04.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5772 5769 0 0 1 2

@antonmyagkov antonmyagkov changed the title issue-1657: add csi-resizer to minikube manifests issue-1657: resize pvc with nbd-lightweight and minikube Sep 16, 2024
@antonmyagkov antonmyagkov force-pushed the users/myagkov/issue-1657-csi-resizer branch from 75def04 to 9d7025a Compare September 17, 2024 15:32
@antonmyagkov antonmyagkov added the blockstore Add this label to run only cloud/blockstore build and tests on PR label Sep 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 9d7025a.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3274 3274 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit c43a693.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3274 3274 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit b49ed6a.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3274 3274 0 0 0 0

qkrorlqr
qkrorlqr previously approved these changes Sep 18, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 3d0c162.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3274 3274 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 969ea38.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3274 3273 0 1 0 0

@antonmyagkov antonmyagkov force-pushed the users/myagkov/issue-1657-csi-resizer branch from 969ea38 to 152442f Compare September 22, 2024 20:25
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 152442f.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3274 3274 0 0 0 0

@antonmyagkov antonmyagkov force-pushed the users/myagkov/issue-1657-csi-resizer branch from 152442f to 4005a54 Compare September 23, 2024 08:42
@antonmyagkov antonmyagkov force-pushed the users/myagkov/issue-1657-csi-resizer branch from 4005a54 to 49df4c0 Compare September 23, 2024 09:25
@antonmyagkov antonmyagkov force-pushed the users/myagkov/issue-1657-csi-resizer branch from d547a40 to e4d6687 Compare September 23, 2024 18:28
@antonmyagkov antonmyagkov force-pushed the users/myagkov/issue-1657-csi-resizer branch from e4d6687 to 6fbc00e Compare September 23, 2024 18:56
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 922d22b.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3281 3281 0 0 0 0

drbasic
drbasic previously approved these changes Sep 24, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit feb9050.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3281 3281 0 0 0 0

drbasic
drbasic previously approved these changes Sep 25, 2024
View reviewed changes
@SvartMetal SvartMetal changed the title issue-1657: resize pvc with nbd-lightweight and minikube issue-1657: resize pvc with nbsd-lightweight and minikube Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 6668b9f.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3281 3281 0 0 0 0

@antonmyagkov antonmyagkov merged commit 58ff545 into main Sep 26, 2024
11 of 14 checks passed
@antonmyagkov antonmyagkov deleted the users/myagkov/issue-1657-csi-resizer branch September 26, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drbasic drbasic drbasic approved these changes

@qkrorlqr qkrorlqr qkrorlqr approved these changes

@SvartMetal SvartMetal Awaiting requested review from SvartMetal

Assignees
No one assigned
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antonmyagkov @qkrorlqr @drbasic @SvartMetal