Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge to stable-23-3: issue-1384 #1688

Merged
merged 1 commit into from
Jul 30, 2024
Merged

merge to stable-23-3: issue-1384 #1688

merged 1 commit into from
Jul 30, 2024

Conversation

antonmyagkov
Copy link
Collaborator

cherry-pick: #1659

@antonmyagkov
issue-1384: destruction of an already destroyed fs should return S_FA…
1af6e2b 
…LSE (#1659)

Problem:
DestroyFileStore for an already destroyed fs returns NKikimrScheme::EStatus::StatusPathDoesNotExist instead of S_FALSE

Bug was introduced in #1441 because DestroyFileStore actor and DescribeSessions actor are handling missing fs in different ways.
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 default-linux-x86-64-relwithdebinfo: all tests PASSED for commit 1af6e2b.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1551 1551 0 0 0 0

@antonmyagkov antonmyagkov merged commit 8467788 into stable-23-3 Jul 30, 2024
6 of 7 checks passed
@antonmyagkov antonmyagkov deleted the users/myagkov/stable-23-3-issue-1384-destroy-fs branch July 30, 2024 13:56
@dvrazumov dvrazumov mentioned this pull request Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gy2411 gy2411 gy2411 approved these changes

@debnatkh debnatkh debnatkh approved these changes

@qkrorlqr qkrorlqr Awaiting requested review from qkrorlqr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonmyagkov @debnatkh @gy2411