-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup agents from DR on REMOVE_HOST cms action #1583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komarevtsev-d
added
large-tests
Launch large tests for PR
blockstore
Add this label to run only cloud/blockstore build and tests on PR
labels
Jul 11, 2024
komarevtsev-d
force-pushed
the
users/komarevtsev-d/issue-1388/2
branch
from
July 12, 2024 12:29
aaf9083
to
c37f309
Compare
This was
linked to
issues
Jul 12, 2024
sharpeye
reviewed
Jul 12, 2024
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
sharpeye
reviewed
Jul 13, 2024
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
sharpeye
reviewed
Jul 13, 2024
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
komarevtsev-d
force-pushed
the
users/komarevtsev-d/issue-1388/2
branch
from
July 15, 2024 04:49
00221a3
to
68aae65
Compare
drbasic
approved these changes
Jul 15, 2024
komarevtsev-d
force-pushed
the
users/komarevtsev-d/issue-1388/2
branch
from
July 15, 2024 06:55
68aae65
to
61bfff6
Compare
sharpeye
approved these changes
Jul 15, 2024
komarevtsev-d
added a commit
that referenced
this pull request
Jul 15, 2024
* Cleanup agents from DR on REMOVE_HOST cms action * review fixes
komarevtsev-d
added a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blockstore
Add this label to run only cloud/blockstore build and tests on PR
large-tests
Launch large tests for PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Первым шагом я начинаю удалять девайсы у агента из DR при вызове REMOVE_HOST. При этом, если на хосте есть диск со сломанным девайсом - поведение не изменится и ни один девайс не будет удалён.
Если все девайсы были удалены, то после выключения агента мы полностью сотрём его из памяти.
По умолчанию поведение также не меняется.
Далее по плану у меня: