Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loop shutdown should not call CancelRequest for inflight requests because it causes a race with the code that's executing those requests, we should simply wait until those requests complete by themselves #1193

Merged
merged 8 commits into from
May 21, 2024
Merged

loop shutdown should not call CancelRequest for inflight requests because it causes a race with the code that's executing those requests, we should simply wait until those requests complete by themselves #1193

merged 8 commits into from
May 21, 2024

Commits on May 15, 2024

  1. loop shutdown should not call CancelRequest for inflight requests bec… 

    …ause it causes a race with the code that's executing those requests, we should simply wait until those requests complete by themselves
    @qkrorlqr
    qkrorlqr committed May 15, 2024
    Configuration menu
    Copy the full SHA
    7705c6a View commit details
    Browse the repository at this point in the history

  2. CompletionQueue shutdown should actually be async + fixed StopAsync b… 

    …ug in TBootstrap in fs_ut.cpp (Apply on a callback which returns TFuture<void> discards the future returned by the callback!)
    @qkrorlqr
    qkrorlqr committed May 15, 2024
    Configuration menu
    Copy the full SHA
    e3d4cd0 View commit details
    Browse the repository at this point in the history

  3. loop shutdown: SuspendAsync ut + some tmp dbg output

    @qkrorlqr
    qkrorlqr committed May 15, 2024
    Configuration menu
    Copy the full SHA
    98c1958 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. loop shutdown: more tmp dbg output

    @qkrorlqr
    qkrorlqr committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c48fd1d View commit details
    Browse the repository at this point in the history

  2. loop shutdown: more tmp dbg output

    @qkrorlqr
    qkrorlqr committed May 16, 2024
    Configuration menu
    Copy the full SHA
    8dc6125 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. loop shutdown: outputting dbg stuff under a lock, outputting dbg stuf… 

    …f only when ShouldStop flag is set
    @qkrorlqr
    qkrorlqr committed May 17, 2024
    Configuration menu
    Copy the full SHA
    77339fb View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. loop shutdown: fixed CompletingCount vs Requests.empty() checks race

    @qkrorlqr
    qkrorlqr committed May 18, 2024
    Configuration menu
    Copy the full SHA
    e074cae View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. loop shutdown: inflight count and completing count should be checked … 

    …together atomically
    @qkrorlqr
    qkrorlqr committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0ad0e2c View commit details
    Browse the repository at this point in the history