[Filestore] issue-652: use currentCommitId-1 instead of currentCommitId for CollectGarbage
#1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debnatkh
added
the
filestore
debnatkh
changed the title
currentCommitId-1 instead of currentCommitId for CollectGarbage
debnatkh
force-pushed
the
users/debnatkh/issue-652-2
branch
from
ca1c5ab
to
ed6336e
Compare
|
Some tests use CollectGarbage and expect all garbage blobs to be collected (including ones with |
qkrorlqr
reviewed
May 8, 2024
qkrorlqr
reviewed
May 8, 2024
qkrorlqr
reviewed
May 8, 2024
qkrorlqr
reviewed
May 8, 2024
cloud/filestore/libs/storage/tablet/tablet_actor_generatecommitid.cpp
Outdated
Show resolved
Hide resolved
debnatkh
force-pushed
the
users/debnatkh/issue-652-2
branch
from
de5ae2c
to
09d8896
Compare
qkrorlqr
previously approved these changes
May 9, 2024
qkrorlqr
previously approved these changes
May 10, 2024
debnatkh
force-pushed
the
users/debnatkh/issue-652-2
branch
from
88cec4a
to
0c551e6
Compare
debnatkh
force-pushed
the
users/debnatkh/issue-652-2
branch
from
0c551e6
to
5d81c2a
Compare
yegorskii
approved these changes
May 14, 2024
qkrorlqr
approved these changes
May 14, 2024
debnatkh
added a commit
that referenced
this pull request
May 24, 2024
…mitId` for `CollectGarbage` (#1135) issue-652: use currentCommitId-1
debnatkh
added a commit
that referenced
this pull request
May 27, 2024
…duce getnodeattr cache (#1272) * [Filestore] issue-652: use `currentCommitId-1` instead of `currentCommitId` for `CollectGarbage` (#1135) issue-652: use currentCommitId-1 * issue-1146: cache `GetNodeAttr` results (#1218) * issue-1146: cache getnodeattr results * fix cmake build for b8dc78c * fix cmake build for 27e48d2 * trigger restart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #652
Cleanup operation acquires a collect barrier with the current commitId to protect the data with the current commitId (or greater) from being tampered with.
Thus, it will be more logical to modify the CollectGarbage operation not to use the
currentCommitId, but usecurrentCommitId - 1, if no barriers are present.