Launch everything under user, upload test artifacts, if test fails, t…

…o s3
ydb-platform · Jan 19, 2024 · b012c04 · b012c04
1 parent fc1dd1f
commit b012c04
Show file tree

Hide file tree

Showing 16 changed files with 304 additions and 64 deletions.
diff --git a/.github/actions/build/action.yaml b/.github/actions/build/action.yaml
@@ -34,9 +34,9 @@ runs:
       shell: bash
       run: |
         echo "SHELLOPTS=xtrace" >> $GITHUB_ENV
-        export TMP_DIR=$(pwd)/tmp_build
+        export TMP_DIR=/home/github/tmp_build
         echo "TMP_DIR=$TMP_DIR" >> $GITHUB_ENV
-        rm -rf $TMP_DIR && mkdir $TMP_DIR
+        rm -rf $TMP_DIR && mkdir $TMP_DIR && chown -R github:github $TMP_DIR $GITHUB_WORKSPACE
 
     - name: build
       shell: bash
@@ -88,18 +88,20 @@ runs:
             ;;
         esac
 
-        ./ya make -k --build "${build_type}" --force-build-depends -D'BUILD_LANGUAGES=CPP PY3 PY2 GO' -T --stat  \
+        sudo -E -H -u github ./ya make -k --build "${build_type}" --force-build-depends -D'BUILD_LANGUAGES=CPP PY3 PY2 GO' -T --stat  \
           --log-file "$TMP_DIR/ya_log.txt" --evlog-file "$TMP_DIR/ya_evlog.jsonl" \
           --dump-graph --dump-graph-to-file "$TMP_DIR/ya_graph.json" \
           --cache-size 512G --link-threads "${{ inputs.link_threads }}" \
           "${extra_params[@]}"
 
+        find
+
     - name: Sync logs to S3
       if: always()
       shell: bash
       run: |
         echo "::group::s3-sync"
-        s3cmd sync --acl-private --no-progress --stats --no-check-md5 "$TMP_DIR/" "$S3_BUCKET_PATH/build_logs/"
+        sudo -E -H -u github s3cmd sync --acl-private --no-progress --stats --no-check-md5 "$TMP_DIR/" "$S3_BUCKET_PATH/build_logs/"
         echo "::endgroup::"
 
     - name: show free space

diff --git a/.github/actions/s3cmd/action.yaml b/.github/actions/s3cmd/action.yaml
@@ -33,7 +33,8 @@ runs:
     - name: configure s3cmd
       shell: bash
       run: |
-        export S3CMD_CONFIG=$(mktemp)
+        export S3CMD_CONFIG=$(mktemp -p /home/github)
+        chown github:github $S3CMD_CONFIG
         echo "S3CMD_CONFIG=$S3CMD_CONFIG" >> $GITHUB_ENV
         export GITHUB_WORKFLOW_NO_SPACES=${GITHUB_WORKFLOW// /-}
         cat <<EOF > $S3CMD_CONFIG

diff --git a/.github/actions/test/action.yaml b/.github/actions/test/action.yaml
@@ -38,23 +38,29 @@ runs:
       shell: bash
       run: |
         echo "SHELLOPTS=xtrace" >> $GITHUB_ENV
-        export TMP_DIR=$(pwd)/tmp
+        export TMP_DIR=/home/github/tmp
         echo "TMP_DIR=$TMP_DIR" >> $GITHUB_ENV
         echo "LOG_DIR=$TMP_DIR/logs" >> $GITHUB_ENV
         echo "OUT_DIR=$TMP_DIR/out" >> $GITHUB_ENV
         echo "ARTIFACTS_DIR=$TMP_DIR/artifacts" >> $GITHUB_ENV
+        echo "TESTS_DATA_DIR=$TMP_DIR/test_data" >> $GITHUB_ENV
+        echo "REPORTS_ARTIFACTS_DIR=$TMP_DIR/artifacts/test_reports" >> $GITHUB_ENV
         echo "JUNIT_REPORT_XML=$TMP_DIR/junit.xml" >> $GITHUB_ENV
-        echo "SUMMARY_LINKS=$(mktemp)" >> $GITHUB_ENV
+        echo "JUNIT_REPORT_PARTS=$TMP_DIR/junit-split" >> $GITHUB_ENV
+        echo "SUMMARY_LINKS=$(mktemp -p /home/github)" >> $GITHUB_ENV
 
     - name: prepare
       shell: bash
       run: |
-        rm -rf $TMP_DIR $JUNIT_REPORT_XML
-        mkdir -p $TMP_DIR $OUT_DIR $ARTIFACTS_DIR $LOG_DIR
-
+        rm -rf $TMP_DIR $JUNIT_REPORT_XML $JUNIT_REPORT_PARTS $REPORTS_ARTIFACTS_DIR $TESTS_DATA_DIR
+        mkdir -p $TMP_DIR $OUT_DIR $ARTIFACTS_DIR $LOG_DIR $JUNIT_REPORT_PARTS $REPORTS_ARTIFACTS_DIR $TESTS_DATA_DIR
+        chown -R github:github $TMP_DIR $OUT_DIR $ARTIFACTS_DIR $LOG_DIR $JUNIT_REPORT_PARTS \
+                               $REPORTS_ARTIFACTS_DIR $SUMMARY_LINKS $GITHUB_WORKSPACE \
+                               $GITHUB_STEP_SUMMARY $TESTS_DATA_DIR
     - name: ya test
       shell: bash
       run: |
+        set -x
         extra_params=()
 
         # FIXME: copy-paste from build_ya
@@ -101,62 +107,112 @@ runs:
         readarray -d ',' -t test_size < <(printf "%s" "${{ inputs.test_size }}")
         readarray -d ',' -t test_type < <(printf "%s" "${{ inputs.test_type }}")
 
-        ./ya test -k --build "${build_type}" -D'BUILD_LANGUAGES=CPP PY3 PY2 GO' \
+        sudo -E -H -u github ./ya test -k --build "${build_type}" -D'BUILD_LANGUAGES=CPP PY3 PY2 GO' \
           ${test_size[@]/#/--test-size=} ${test_type[@]/#/--test-type=} \
           --test-threads "${{ inputs.test_threads }}" --link-threads "${{ inputs.link_threads }}" \
           --cache-size 512G --do-not-output-stderrs -T \
           --stat --log-file "$LOG_DIR/ya_log.txt" --evlog-file "$LOG_DIR/ya_evlog.jsonl" \
           --canonization-backend=ydb-canondata.storage.yandexcloud.net \
           --junit "$JUNIT_REPORT_XML" --output "$OUT_DIR" "${extra_params[@]}" || (
             RC=$?
-            if [[ $RC -ge 10 && $RC -le 14 ]]; then
-              echo "ya test returned failed tests status, recovering.."
-            else
-              exit $RC
+            if [ $RC -ne 0 ]; then
+              echo "ya test returned $RC, check existence $JUNIT_REPORT_XML"
+              if [ -s "$JUNIT_REPORT_XML" ]; then
+                echo "$JUNIT_REPORT_XML exists"
+                ls -la "$JUNIT_REPORT_XML"
+              else
+                echo "$JUNIT_REPORT_XML doesn't exist or has zero size"
+                ls -la "$JUNIT_REPORT_XML" || true
+                exit $RC
+              fi
             fi
         )
 
+    - name: archive unitest reports (orig)
+      shell: bash
+      run: |
+        sudo -E -H -u github gzip -c $JUNIT_REPORT_XML > $REPORTS_ARTIFACTS_DIR/orig_junit.xml.gz
+
     - name: postprocess junit report
       shell: bash
       run: |
-        .github/scripts/tests/transform-ya-junit.py -i \
+        sudo -E -H -u github .github/scripts/tests/transform-ya-junit.py -i \
           -m .github/config/muted_ya.txt \
           --ya-out "$OUT_DIR" \
           --log-url-prefix "$S3_WEBSITE_PREFIX/logs/" \
           --log-out-dir "$ARTIFACTS_DIR/logs/" \
           "$JUNIT_REPORT_XML"
 
+        sudo -E -H -u github .github/scripts/tests/split-junit.py -o "$JUNIT_REPORT_PARTS" "$JUNIT_REPORT_XML"
+
+    - name: archive unitest reports (transformed)
+      shell: bash
+      run: |
+        sudo -E -H -u github tar -C $JUNIT_REPORT_PARTS/.. -czf $REPORTS_ARTIFACTS_DIR/junit_parts.xml.tar.gz $(basename $JUNIT_REPORT_PARTS) $JUNIT_REPORT_XML
+
     - name: write tests summary
       shell: bash
       env:
         GITHUB_TOKEN: ${{ github.token }}
       run: |
-        mkdir $ARTIFACTS_DIR/summary/
+        sudo -E -H -u github mkdir $ARTIFACTS_DIR/summary/
 
         cat $SUMMARY_LINKS | python3 -c 'import sys; print(" | ".join([v for _, v in sorted([l.strip().split(" ", 1) for l in sys.stdin], key=lambda a: (int(a[0]), a))]))' >> $GITHUB_STEP_SUMMARY
 
         platform_name=$(uname | tr '[:upper:]' '[:lower:]')-$(arch)
 
-        .github/scripts/tests/generate-summary.py \
+        export SUMMARY_OUT_ENV_PATH=$(mktemp -p /home/github)
+        chown github:github $SUMMARY_OUT_ENV_PATH
+        sudo -E -H -u github .github/scripts/tests/generate-summary.py \
           --summary-out-path "$ARTIFACTS_DIR/summary/" \
+          --summary-out-env-path "$SUMMARY_OUT_ENV_PATH" \
           --summary-url-prefix "$S3_WEBSITE_PREFIX/summary/" \
           --build-preset "${platform_name}-${{ inputs.build_preset }}" \
           "Tests" ya-test.html "$JUNIT_REPORT_XML"
 
+        cat $SUMMARY_OUT_ENV_PATH | tee -a $GITHUB_STEP_SUMMARY
+
+    - name: check test results
+      shell: bash
+      run: |
+        set -x
+        sudo -E -H -u github .github/scripts/tests/fail-checker.py "$JUNIT_REPORT_XML" || {
+          RC=$?
+
+          echo "::group::Copy-failed-tests-data"
+          sudo -E -H -u github .github/scripts/tests/fail-checker.py "$JUNIT_REPORT_XML" --paths-only
+          sudo -E -H -u github .github/scripts/tests/fail-checker.py "$JUNIT_REPORT_XML" --paths-only | while read path; do
+            echo $path
+            find "${GITHUB_WORKSPACE}/${path}" -print0 | xargs -0 xargs -0 cp -L -r --parents -t "$TESTS_DATA_DIR"
+          done
+          echo "::endgroup::"
+          echo "::group::s3-sync"
+          sudo -E -H -u github s3cmd sync --follow-symlinks --acl-private --no-progress --stats --no-check-md5 "$TESTS_DATA_DIR/" "$S3_BUCKET_PATH/test_data/"
+          echo "::endgroup::"
+          exit $RC
+        }
+
     - name: Sync test results to S3
       if: always()
       shell: bash
       run: |
         echo "::group::s3-sync"
-        s3cmd sync --follow-symlinks --acl-public --no-progress --stats --no-check-md5 "$ARTIFACTS_DIR/" "$S3_BUCKET_PATH/"
+        sudo -E -H -u github s3cmd sync --follow-symlinks --acl-public --no-progress --stats --no-check-md5 "$ARTIFACTS_DIR/" "$S3_BUCKET_PATH/"
         echo "::endgroup::"
 
     - name: Sync logs results to S3
       if: always()
       shell: bash
       run: |
         echo "::group::s3-sync"
-        s3cmd sync --follow-symlinks --acl-private --no-progress --stats --no-check-md5 "$LOG_DIR/" "$S3_BUCKET_PATH/test_logs/"
+        sudo -E -H -u github s3cmd sync --follow-symlinks --acl-private --no-progress --stats --no-check-md5 "$LOG_DIR/" "$S3_BUCKET_PATH/test_logs/"
+        echo "::endgroup::"
+    - name: Sync reports to S3
+      if: always()
+      shell: bash
+      run: |
+        echo "::group::s3-sync"
+        sudo -E -H -u github s3cmd sync --follow-symlinks --acl-private --no-progress --stats --no-check-md5 "$LOG_DIR/" "$S3_BUCKET_PATH/test_logs/"
         echo "::endgroup::"
 
     - name: Display links to s3 summary
@@ -167,12 +223,15 @@ runs:
         echo ${S3_URL_PREFIX}/summary/ya-test.html
         echo ${S3_WEBSITE_PREFIX}/summary/ya-test.html
         echo "::endgroup::"
-    - name: check test results
-      shell: bash
-      run: |
-        .github/scripts/tests/fail-checker.py "$JUNIT_REPORT_XML"
+
+
 
     - name: show free space
       if: always()
       shell: bash
       run: df -h
+
+    - name: failure
+      if: always()
+      shell: bash
+      run: sleep 3600
diff --git a/.github/scripts/tests/attach-logs.py b/.github/scripts/tests/attach-logs.py
@@ -7,8 +7,20 @@
 from xml.etree import ElementTree as ET
 from pathlib import Path
 from typing import List
-from log_parser import ctest_log_parser, parse_yunit_fails, parse_gtest_fails, log_reader, GTEST_MARK, YUNIT_MARK
-from junit_utils import add_junit_log_property, create_error_testcase, create_error_testsuite, suite_case_iterator
+from log_parser import (
+    ctest_log_parser,
+    parse_yunit_fails,
+    parse_gtest_fails,
+    log_reader,
+    GTEST_MARK,
+    YUNIT_MARK,
+)
+from junit_utils import (
+    add_junit_log_property,
+    create_error_testcase,
+    create_error_testsuite,
+    suite_case_iterator,
+)
 from ctest_utils import CTestLog
 
 fn_shard_part_re = re.compile(r"-\d+$")
@@ -132,24 +144,35 @@ def attach_to_unittests(ctest_log: CTestLog, unit_path):
 
         fn = f"{shard}-0000.xml"
         print(f"create {fn}")
-        testcases = [create_error_testcase(t.shard.name, t.classname, t.method, t.fn, t.url) for t in extra_logs]
+        testcases = [
+            create_error_testcase(t.shard.name, t.classname, t.method, t.fn, t.url)
+            for t in extra_logs
+        ]
 
         testsuite = create_error_testsuite(testcases)
-        testsuite.write(os.path.join(unit_path, fn), xml_declaration=True, encoding="UTF-8")
+        testsuite.write(
+            os.path.join(unit_path, fn), xml_declaration=True, encoding="UTF-8"
+        )
 
 
 def main():
     parser = argparse.ArgumentParser()
     parser.add_argument("--url-prefix", default="./")
-    parser.add_argument("--decompress", action="store_true", default=False, help="decompress ctest log")
+    parser.add_argument(
+        "--decompress", action="store_true", default=False, help="decompress ctest log"
+    )
     parser.add_argument("--ctest-report")
     parser.add_argument("--junit-reports-path")
     parser.add_argument("ctest_log")
     parser.add_argument("out_log_dir")
 
     args = parser.parse_args()
 
-    ctest_log = extract_logs(log_reader(args.ctest_log, args.decompress), Path(args.out_log_dir), args.url_prefix)
+    ctest_log = extract_logs(
+        log_reader(args.ctest_log, args.decompress),
+        Path(args.out_log_dir),
+        args.url_prefix,
+    )
 
     if ctest_log.has_logs:
         attach_to_ctest(ctest_log, args.ctest_report)

diff --git a/.github/scripts/tests/ctest-postprocess.py b/.github/scripts/tests/ctest-postprocess.py
@@ -65,7 +65,9 @@ def main():
     parser = argparse.ArgumentParser()
     parser.add_argument("--dry-run", action="store_true", default=False)
     parser.add_argument("--filter-file", required=False)
-    parser.add_argument("--decompress", action="store_true", default=False, help="decompress ctest log")
+    parser.add_argument(
+        "--decompress", action="store_true", default=False, help="decompress ctest log"
+    )
     parser.add_argument("ctest_log", type=str)
     parser.add_argument("ctest_junit_report")
     args = parser.parse_args()

diff --git a/.github/scripts/tests/ctest_utils.py b/.github/scripts/tests/ctest_utils.py
@@ -56,7 +56,9 @@ def __init__(self):
 
     def add_shard(self, name, status, log_url):
         common_name = get_common_shard_name(name)
-        shard = self.storage[common_name][name] = self.name_shard[name] = CTestLogShard(name, status, log_url)
+        shard = self.storage[common_name][name] = self.name_shard[name] = CTestLogShard(
+            name, status, log_url
+        )
         return shard
 
     def has_error_shard(self, name):

diff --git a/.github/scripts/tests/fail-checker.py b/.github/scripts/tests/fail-checker.py
@@ -27,11 +27,35 @@ def check_for_fail(paths: List[str]):
         raise SystemExit(-1)
 
 
+def get_fail_dirs(paths: List[str]):
+    failed_list = set()
+    error_list = set()
+    for path in paths:
+        for fn, suite, case in iter_xml_files(path):
+            is_failure = case.find("failure") is not None
+            is_error = case.find("error") is not None
+            test_name = f"{case.get('classname')}"
+            if is_failure:
+                failed_list.add(test_name)
+            elif is_error:
+                error_list.add(test_name)
+
+    if failed_list or error_list:
+        for t in failed_list:
+            print(t)
+        for t in error_list:
+            print(t)
+
+
 def main():
     parser = argparse.ArgumentParser()
     parser.add_argument("path", nargs="+", help="jsuite xml reports directories")
+    parser.add_argument("--paths-only", default=False, action="store_true")
     args = parser.parse_args()
-    check_for_fail(args.path)
+    if args.paths_only:
+        get_fail_dirs(args.path)
+    else:
+        check_for_fail(args.path)
 
 
 if __name__ == "__main__":