NBSNEBIUS-86: rendering raw volume config (pretty-printed proto) on v…

…olume monpage (#220) * NBSNEBIUS-86: rendering raw volume config (pretty-printed proto) on volume monpage * NBSNEBIUS-86: rendering raw volume config (pretty-printed proto) on volume monpage
ydb-platform · Jan 24, 2024 · 6698b18 · 6698b18
1 parent b3e0004
commit 6698b18
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/cloud/blockstore/libs/storage/volume/volume_actor.h b/cloud/blockstore/libs/storage/volume/volume_actor.h
@@ -408,6 +408,7 @@ class TVolumeActor final
     void RenderCheckpoints(IOutputStream& out) const;
     void RenderTraces(IOutputStream& out) const;
     void RenderStorageConfig(IOutputStream& out) const;
+    void RenderRawVolumeConfig(IOutputStream& out) const;
     void RenderCommonButtons(IOutputStream& out) const;
 
     void OnDetach(const NActors::TActorContext& ctx) override;

diff --git a/cloud/blockstore/libs/storage/volume/volume_actor_monitoring.cpp b/cloud/blockstore/libs/storage/volume/volume_actor_monitoring.cpp
@@ -448,6 +448,7 @@ void TVolumeActor::HandleHttpInfo_Default(
     const char* checkpointsTabName = "Checkpoints";
     const char* tracesTabName = "Traces";
     const char* storageConfigTabName = "StorageConfig";
+    const char* rawVolumeConfigTabName = "RawVolumeConfig";
 
     const char* activeTab = "tab-pane active";
     const char* inactiveTab = "tab-pane";
@@ -457,6 +458,7 @@ void TVolumeActor::HandleHttpInfo_Default(
     const char* checkpointsTab = inactiveTab;
     const char* tracesTab = inactiveTab;
     const char* storageConfigTab = inactiveTab;
+    const char* rawVolumeConfigTab = inactiveTab;
 
     if (tabName.Empty() || tabName == overviewTabName) {
         overviewTab = activeTab;
@@ -468,6 +470,8 @@ void TVolumeActor::HandleHttpInfo_Default(
         tracesTab = activeTab;
     } else if (tabName == storageConfigTabName) {
         storageConfigTab = activeTab;
+    } else if (tabName == rawVolumeConfigTabName) {
+        rawVolumeConfigTab = activeTab;
     }
 
     TStringStream out;
@@ -497,6 +501,10 @@ void TVolumeActor::HandleHttpInfo_Default(
                 DIV_CLASS_ID(storageConfigTab, storageConfigTabName) {
                     RenderStorageConfig(out);
                 }
+
+                DIV_CLASS_ID(rawVolumeConfigTab, rawVolumeConfigTabName) {
+                    RenderRawVolumeConfig(out);
+                }
             }
         }
     }
@@ -777,6 +785,27 @@ void TVolumeActor::RenderStorageConfig(IOutputStream& out) const
     }
 }
 
+void TVolumeActor::RenderRawVolumeConfig(IOutputStream& out) const
+{
+    if (!State) {
+        return;
+    }
+
+    const auto& volumeConfig = State->GetMeta().GetVolumeConfig();
+
+    HTML(out) {
+        DIV_CLASS("row") {
+            TAG(TH3) {
+                out << "RawVolumeConfig";
+            }
+
+            PRE() {
+                SerializeToTextFormatPretty(volumeConfig, out);
+            }
+        }
+    }
+}
+
 void TVolumeActor::RenderHtmlInfo(IOutputStream& out, TInstant now) const
 {
     using namespace NMonitoringUtils;