Skip to content

Commit

Permalink
staged csi: add comment to remember enable check later
Browse files Browse the repository at this point in the history
According to spec target directory must be removed after NodeUnstage
but now mounter mock doesn't delete it during mount point cleanup.
If directory deletion is enabled then other test breaks because it
relies on previous tests leaving temoprary directories.

This will be fixed separately form this PR.

Signed-off-by: Anton Kuchin <[email protected]>
  • Loading branch information
aikuchin committed Sep 23, 2024
1 parent 2267fd2 commit 2271f27
Showing 1 changed file with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,13 @@ func doTestStagedPublishUnpublishVolumeForKubevirt(t *testing.T, backend string,
})
require.NoError(t, err)

// TODO: enable check that target directory is deleted
// mock mounter should remove targetPath but if it does then TestGetVolumeStatCapabilitiesWithoutVmMode
// fails because it relies on other tests leaving target directory (it fails if launched alone)
//
//_, err = os.Stat(targetPath)
//assert.True(t, os.IsNotExist(err))

if backend == "nbs" {
nbsClient.On("StopEndpoint", ctx, &nbs.TStopEndpointRequest{
UnixSocketPath: nbsSocketPath,
Expand Down

0 comments on commit 2271f27

Please sign in to comment.