Added POST capabilities #419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added POST to WebURL and PageFetcher. Included support for the new WebURL attributes in WebURLTupleBinding. I've suggested to deprecate newHttpUriRequest(String) in PageFetcher because it does not allow to pass post parameters.
DocIDServer is now aware of POST data and allows to visit the same URL if POST parameters are different. (Filling a form with different years, for instance). Suggested to deprecate getDocId, getNewDocID, addUrlAndDocId and isSeenBefore since they don't allow to pass post parameters. WebURL has the ability to encode itself into a single unique string. NOTE: This serialization SHOULD be improved.
The WebCrawler now passes the WebURL to the DocIDServer instead of passing a String URL. We assume GET on redirections. I'm not 100% sure if this is allways true. The case !curURL.getURL().equals(fetchResult.getFetchedUrl()) is still using old methods. Should be reviewed
Added addSeenUrl(WebURL) and addSeed(WebURL) methods to CrawlController. Did not touch original methods, although I'd suggest to make them create WebURLs and pass them to the new methods.
addSeed and addSeenUrl now will create a WebURL and pass it to the newly created methods. It will make it easier for the user to override those methods.
Suggedted to deprecate old fetchedUrl attribute and introduced fetchedWebUrl, which is a WebURL. Some tab style fixes.
There was a loop. Some style fixes.
|
I dont know why the building process failed. I did not touch any of the gradle files, as you can see, there are only some minor modifications in classes... |
Now WebURLs can be used as seeds, so we enforce docId to be < 0 unless staten otherwise
Silly changes to pass Travis test now that java8 bug is fixed
PostParameters are now an abstraction, so subclases of WebURL can produce custom behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for POST requests by using isPost() method in WebURL.
This commit allows users to add WebURLs and mark them as POST URLs. Current parsers do not get PostURLs, however, users can add their custom post URLs either as seeds or using the visit() method.
It is based on the authentication methods already provided by Crawler4j.
May need improvement in DocIDServer because it is using an encoded version of the URL with all the POST data. Encoding / decoding of WebURLs to string for DBs could also be improved (maybe using a hash?)
Modifications
I don't know gradle, so I'm not sure why this is giving compile errors on travis, but it seems that there's a problem in the config or in the master, rather than in my commit. Could someone please take a look?