Deadlink #373
Open
Deadlink #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* also add pdf to the ignored files list * fix logging setup
Previously only the first link which leads to an error page got reported. This change will keep track of those links and also write a report if the same link is used on a subsequent page. We now also write subfolders per domain.
|
Wow, Thank you @struberg I didn't review it all, but it seems really impressive. I'd love to see it merged into the example code in this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sample project in form of an app which detects dead links on a page.
See /crawler4j-examples/deadlinksniffer.
There is surely room for improvement but it already works reasonably well.
I'd be happy to continue working on it for now, this PR is just for gathering feedback in case I did something completely wrong in the code.