Skip to content

Commit

Permalink
Update go version in go.mod (#269)
Browse files Browse the repository at this point in the history
* Downgrade to latest version supported by goreleaser
  • Loading branch information
yannh authored May 9, 2024
1 parent 14053aa commit 9627dd1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ local-build-static:

# These only used for development. Release artifacts and docker images are produced by goreleaser.
docker-test:
docker run -t -v $$PWD:/go/src/github.com/yannh/kubeconform -w /go/src/github.com/yannh/kubeconform golang:1.22.3 make local-test
docker run -t -v $$PWD:/go/src/github.com/yannh/kubeconform -w /go/src/github.com/yannh/kubeconform golang:1.22.1 make local-test

docker-build:
docker run -t -v $$PWD:/go/src/github.com/yannh/kubeconform -w /go/src/github.com/yannh/kubeconform golang:1.22.3 make local-build
docker run -t -v $$PWD:/go/src/github.com/yannh/kubeconform -w /go/src/github.com/yannh/kubeconform golang:1.22.1 make local-build

docker-build-static:
docker run -t -v $$PWD:/go/src/github.com/yannh/kubeconform -w /go/src/github.com/yannh/kubeconform golang:1.22.3 make local-build-static
docker run -t -v $$PWD:/go/src/github.com/yannh/kubeconform -w /go/src/github.com/yannh/kubeconform golang:1.22.1 make local-build-static

build-bats:
docker build -t bats -f Dockerfile.bats .
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/yannh/kubeconform

go 1.21
go 1.22.1

This comment has been minimized.

Copy link
@bitti

bitti May 9, 2024

Contributor

Now I'm getting

github.com/yannh/kubeconform/cmd/kubeconform@latest (in github.com/yannh/[email protected]): go.mod:3: invalid go version '1.22.1': must match format 1.23

Go version itself is go1.20.12 linux/amd64. How to fix this short of manually patching this file?

This comment has been minimized.

Copy link
@yannh

yannh May 9, 2024

Author Owner

Well sorry looks like it must be major.minor and not major.minor.patch? I pushed a hotfix I hope this fixes it :(

This comment has been minimized.

Copy link
@bitti

bitti May 10, 2024

Contributor

Thanks! It seems like it. Maybe major.minor.patch is supported by newer Go versions? Although go1.20.12 is not really that old.


require (
github.com/santhosh-tekuri/jsonschema/v5 v5.3.1
Expand Down

0 comments on commit 9627dd1

Please sign in to comment.