Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't import deprecated "wheel" (just to do nothing with it) #823

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

henryiii
Copy link

The wheel package is no longer a dependency of setuptools, so trying to import from it might wipe out the integrated setuptools bdist_wheel command, and will start proceeding a warning or error soon. Since nothing at all is done to it (anymore?), just drop it.

@pelson
Copy link

pelson commented Oct 7, 2024

It turns out that this is necessary to work with the main of setuptools (at least currently). I would recommend merging this proposed change for all of the reasons already outlined. It may be a good idea to put a minimum version of setuptools>=70.1 (https://setuptools.pypa.io/en/stable/history.html#v70-1-0) if bdist_wheel is a requirement.

@henryiii
Copy link
Author

It's not needed (it's not doing anything), so you shouldn't need the minimum. Setuptools (from the first version that supports PEP 517, version 41!) declares it needs wheel in get_requires_for_build_wheel.

@henryiii
Copy link
Author

@nitzmahone setuptools is trying to make a release, but pyyaml is in setuptool's tests and it won't work with the new version of setuptools without this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants