Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for quantile and quantileIf functions #303

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

aronbierbaum
Copy link
Contributor

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.

@coveralls
Copy link

coveralls commented Mar 22, 2024

Coverage Status

coverage: 85.986% (+0.04%) from 85.943%
when pulling 0cea38d on aronbierbaum:add_quantile
into ac9442a on xzkostyan:master.

@aronbierbaum
Copy link
Contributor Author

@xzkostyan Could you review the addition of custom quantile and quantileIf functions. The main issue I ran into is that using the default function proxy does not support generating quantile(0.75)(column). In order to support the function I added a custom function that compiles quantile(0.75, column) to quantile(0.75)(column).

@xzkostyan xzkostyan merged commit 0794e94 into xzkostyan:master Mar 26, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants