Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aggregate types #297

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Conversation

aronbierbaum
Copy link
Contributor

@aronbierbaum aronbierbaum commented Mar 4, 2024

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.

@xzkostyan
Copy link
Owner

@aronbierbaum aronbierbaum force-pushed the add_aggregate_types branch 3 times, most recently from b7b3df1 to 0357236 Compare March 22, 2024 19:43
@coveralls
Copy link

coveralls commented Mar 22, 2024

Coverage Status

coverage: 85.946% (+0.003%) from 85.943%
when pulling e77c82f on aronbierbaum:add_aggregate_types
into ac9442a on xzkostyan:master.

@aronbierbaum
Copy link
Contributor Author

@xzkostyan I have addressed the test suite issues by requiring a higher version of ClickHouse where needed. This has caused the coverage to decrease on some combinations though.

@xzkostyan xzkostyan merged commit 83c5b46 into xzkostyan:master Mar 26, 2024
61 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants