Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parsing): change the way to quote db_url to fix the test broken by sqlalchemy 2.0.25 #285

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

Net-Mist
Copy link
Contributor

@Net-Mist Net-Mist commented Jan 19, 2024

Hello,

Currently, tests are broken on master because of an update of sqlalchemy. This fix corrects the failing test.
Note that in the test, I remove the space of the password because it now fails (on purpose) because it is not RFC-1738 compliment.

For context, see

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.

@coveralls
Copy link

Coverage Status

coverage: 85.756% (-0.005%) from 85.761%
when pulling 4a4931f on Net-Mist:parsing_tests
into c34be61 on xzkostyan:master.

@xzkostyan
Copy link
Owner

Hi.

In SA >= 2.0.25 we don't need quoting, but in SA < 2.0.24 we need it? If so, we need to support both quoting and no-quoting behavior.

@Net-Mist
Copy link
Contributor Author

Hi,
the code already supports quoting and no-quoting (both are tested in the test, maybe you prefer if it is 2 different tests ?)
the main difference is the make_url function that previously was using custom regex. see old code vs new one

@limonyellow limonyellow mentioned this pull request Feb 10, 2024
5 tasks
@xzkostyan xzkostyan merged commit dc378ec into xzkostyan:master Feb 17, 2024
27 of 52 checks passed
xzkostyan added a commit that referenced this pull request Feb 17, 2024
@Net-Mist Net-Mist deleted the parsing_tests branch February 21, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants