Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove greenlet dependency #257

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Remove greenlet dependency #257

merged 1 commit into from
Jul 27, 2023

Conversation

mrcljx
Copy link
Contributor

@mrcljx mrcljx commented Jul 19, 2023

The greenlet>=2.0.1 requirement is forced on all projects importing this package, but it's actually not imported (except from tests for which it already is listed in testsrequire.py).

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.

The `greenlet>=2.0.1` requirement is forced on all projects importing this package, but it's actually not imported (except from tests for which it already is listed in `testsrequire.py`).
@xzkostyan
Copy link
Owner

@randomowo do you have any idea why we need this specific version?

@coveralls
Copy link

Coverage Status

coverage: 85.736%. remained the same when pulling 2aba46d on mrcljx:patch-1 into 9545a17 on xzkostyan:master.

@xzkostyan xzkostyan merged commit 060c601 into xzkostyan:master Jul 27, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants