Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Array attributes #255

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

jonburdo
Copy link
Contributor

@jonburdo jonburdo commented Jul 11, 2023

Array previously threw a NotImplementedError for the python_type attribute and returned True for hashable.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.

@jonburdo jonburdo marked this pull request as draft July 11, 2023 20:28
Array previously threw a NotImplementedError for the python_type
attribute and returned True instead of False for hashable.
@jonburdo jonburdo changed the title Change Array to subclass SQLAlchemy's ARRAY Add missing Array attributes Jul 11, 2023
@jonburdo jonburdo marked this pull request as ready for review July 11, 2023 20:37
@coveralls
Copy link

Coverage Status

coverage: 85.736% (+0.4%) from 85.376% when pulling 49ef908 on jonburdo:fix-array-attributes into 800dcfb on xzkostyan:master.

@xzkostyan xzkostyan merged commit 9545a17 into xzkostyan:master Jul 12, 2023
35 checks passed
@jonburdo jonburdo deleted the fix-array-attributes branch July 12, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array has incorrect attributes
3 participants