Skip to content

Commit

Permalink
UPSTREAM: netfilter: nf_tables: skip bound chain on rule flush
Browse files Browse the repository at this point in the history
[ Upstream commit 6eaf41e87a223ae6f8e7a28d6e78384ad7e407f8 ]

Skip bound chain when flushing table rules, the rule that owns this
chain releases these objects.

Otherwise, the following warning is triggered:

  WARNING: CPU: 2 PID: 1217 at net/netfilter/nf_tables_api.c:2013 nf_tables_chain_destroy+0x1f7/0x210 [nf_tables]
  CPU: 2 PID: 1217 Comm: chain-flush Not tainted 6.1.39 projectceladon#1
  RIP: 0010:nf_tables_chain_destroy+0x1f7/0x210 [nf_tables]

Bug: 294357305
Fixes: d0e2c7d ("netfilter: nf_tables: add NFT_CHAIN_BINDING")
Reported-by: Kevin Rich <[email protected]>
Signed-off-by: Pablo Neira Ayuso <[email protected]>
Signed-off-by: Florian Westphal <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
(cherry picked from commit e18922ce3e3169eb97838d1dcba2d679bcca446c)
Signed-off-by: Lee Jones <[email protected]>
Change-Id: I48f43d0ce3410efec2513479a1f4c7708a097b01
  • Loading branch information
ummakynes authored and Treehugger Robot committed Aug 16, 2023
1 parent dc2a55f commit eec4968
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions net/netfilter/nf_tables_api.c
Original file line number Diff line number Diff line change
Expand Up @@ -3744,6 +3744,8 @@ static int nf_tables_delrule(struct sk_buff *skb, const struct nfnl_info *info,
list_for_each_entry(chain, &table->chains, list) {
if (!nft_is_active_next(net, chain))
continue;
if (nft_chain_is_bound(chain))
continue;

ctx.chain = chain;
err = nft_delrule_by_chain(&ctx);
Expand Down

0 comments on commit eec4968

Please sign in to comment.