-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pitch: explore a single examples app for all react + svelte examples. #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
Went through to make sure everywhere that has an example / uses the code viewer works. Here's the issues I found. React Flow:
Svelte Flow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current approach to developing examples for reactflow and svelteflow is less than ideal. We take different approaches for each framework, with react examples being nested deep in the site's source under the example-viewer component and svelte examples being an entirely separate SvelteKit app. It makes authoring examples quite challenging, and then making sure examples are kept broadly in-sync across frameworks is another challenge on top.
This PR seeks to address that by unifying the way we develop and serve examples under one roof.
examples-app
application that is a multi-page Vite app that (theoretical) contains every example.source.json
file that contains a map for the example's source files and any of its dependencies.IframeViewer
component that works similarly to the svelte example viewer, connecting to this examples app and rendering an iframe preview or the source fromsource.json
.There are still some todos:
xy-ui
now that we're using the same approach for both.build
andserve
scripts have some duplicated code that could be refactored potentially.Porting our existing examples is out of scope for this PR.