This repository has been archived by the owner on Jan 16, 2023. It is now read-only.
removed unnecessary explicit case for escape key being pressed and... #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded option to allow multiple inputs to the external key handler at once.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...added option to allow multiple inputs to the external key handler at once.
The condition at main.c line 589-590
if (ksym == XK_Escape && MODMASK(kev->state) == 0) { extprefix = False;is unnecessary because extprefix is set to false on line 593 no matter which key is pressed, including escape. Also, explicitly checking for XK_Escape means the user can't bind any commands to the escape key (i prefer to bind esc to 'exit without output' if possible). Also I added one_keyhandler_cmd, but the diff for config.def.h explains that well enough.