#340: Create htmlcomment macro bridge #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trrenty
requested changes
Oct 2, 2024
| * 02110-1301 USA, or see the FSF site: http://www.fsf.org. | ||
| --> | ||
|
|
||
| <xwikidoc version="1.5" reference="Confluence.Macros.HtmlComment" locale=""> |
There was a problem hiding this comment.
Did you export the page using a 14.10 xwiki instance?
There was a problem hiding this comment.
No I developed with a 16.04 instance. Should I re-export from a 14.10 instance ?
There was a problem hiding this comment.
Yes. The current parent of the pro-macros is 13.10. However, we need to upgrade it to 14.10 asap. It should be ok for you export this macro from a 14.10 instance
There was a problem hiding this comment.
Did a import/export from a 14.10 instance. I still have the xwikidoc version="1.5" but some class fields was updated.
.../xwiki-pro-macros-confluence-bridges-ui/src/main/resources/Confluence/Macros/HtmlComment.xml
Outdated
Show resolved
Hide resolved
.../xwiki-pro-macros-confluence-bridges-ui/src/main/resources/Confluence/Macros/HtmlComment.xml
Outdated
Show resolved
Hide resolved
.../xwiki-pro-macros-confluence-bridges-ui/src/main/resources/Confluence/Macros/HtmlComment.xml
Outdated
Show resolved
Hide resolved
.../xwiki-pro-macros-confluence-bridges-ui/src/main/resources/Confluence/Macros/HtmlComment.xml
Outdated
Show resolved
Hide resolved
.../xwiki-pro-macros-confluence-bridges-ui/src/main/resources/Confluence/Macros/HtmlComment.xml
Outdated
Show resolved
Hide resolved
…e-bridges-ui/src/main/resources/Confluence/Macros/HtmlComment.xml Co-authored-by: Teo Caras <[email protected]>
…e-bridges-ui/src/main/resources/Confluence/Macros/HtmlComment.xml Co-authored-by: Teo Caras <[email protected]>
…e-bridges-ui/src/main/resources/Confluence/Macros/HtmlComment.xml Co-authored-by: Teo Caras <[email protected]>
* Rename page for more consistency
trrenty
reviewed
Oct 7, 2024
...-macros-confluence-bridges-ui/src/main/resources/Confluence/Macros/ConfluenceHtmlComment.xml
Outdated
Show resolved
Hide resolved
...-macros-confluence-bridges-ui/src/main/resources/Confluence/Macros/ConfluenceHtmlComment.xml
Outdated
Show resolved
Hide resolved
…e-bridges-ui/src/main/resources/Confluence/Macros/ConfluenceHtmlComment.xml Co-authored-by: Teo Caras <[email protected]>
…e-bridges-ui/src/main/resources/Confluence/Macros/ConfluenceHtmlComment.xml Co-authored-by: Teo Caras <[email protected]>
* Fix velocity if check
* Re-export macro page from 14.10 instance * Fix typo * Add missing licence check
trrenty
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
htmlcommentmacro.cf: #340