Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The UI in the "Link..." section appears messed up #287 #308

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

Farcasut
Copy link

@Farcasut Farcasut commented Nov 4, 2024

The recent draw.io upgrade broke some CSS across different tabs. This PR should resolve all related issues. I’ve linked all CSS-related issues to this PR so they can be merged in a single update.

…nged slightly, and now it returns the submenu. This issue occurred because our function did not return the submenu, which could later lead to a type error.
* In version 22.0.0, Draw.io updated the way it computes the icon path. It now relies on a new global variable called DRAWIO_SERVER_URL, which is based on the current server address. Due to this change, requests intended for Draw.io are mistakenly made locally instead of to the external Draw.io server.

https://github.com/jgraph/drawio/blame/acd938b1e42cff3be3b629e6239cdec9a9baddcc/src/main/webapp/js/diagramly/Init.js#L51

https://github.com/jgraph/drawio/blame/acd938b1e42cff3be3b629e6239cdec9a9baddcc/src/main/webapp/js/diagramly/Init.js#L25
Copy link

@oanalavinia oanalavinia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to mention all issues when merging it

@Farcasut Farcasut linked an issue Nov 8, 2024 that may be closed by this pull request
@Farcasut Farcasut changed the title Broken css The UI in the "Link..." section appears messed up #287 Nov 8, 2024
@Farcasut Farcasut merged commit c4e70c4 into xwikisas:Upgrade-drawio-24.5.5 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants