Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XWIKI-22635: On restart, documents to re-index aren't correctly computed #3622

Merged
merged 2 commits into from
Nov 7, 2024
Merged

XWIKI-22635: On restart, documents to re-index aren't correctly computed #3622

merged 2 commits into from
Nov 7, 2024

Conversation

michitux
Copy link
Contributor

@michitux michitux commented Nov 5, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-22635

Changes

Description

  • Use an internal comparator that reproduces the order of Solr/the database.
  • Add an integration test to verify that the sort order corresponds to the used comparator.

Clarifications

  • This also improves the test to give more helpful errors in case the sorting order is different between database and Solr.

Screenshots & Video

Executed Tests

mvn clean install -Pquality,integration-tests,docker -pl :xwiki-platform-search-test-docker,:xwiki-platform-search-solr-api

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • No idea, but might be a good idea to backport.

@michitux
XWIKI-22635: On restart, documents to re-index aren't correctly computed
7fccafe 
* Use an internal comparator that reproduces the order of Solr/the
  database.
* Add an integration test to verify that the sort order corresponds to
  the used comparator.
@michitux
XWIKI-22635: On restart, documents to re-index aren't correctly computed
93ddd66 
* Remove outdated comment.
@michitux michitux self-assigned this Nov 6, 2024
@michitux michitux merged commit 4a5e7b0 into xwiki:master Nov 7, 2024
1 check passed
@michitux michitux deleted the XWIKI-22635 branch November 7, 2024 08:39
michitux added a commit that referenced this pull request Nov 7, 2024
@michitux
XWIKI-22635: On restart, documents to re-index aren't correctly compu…
5d69b34 
…ted (#3622)

* Use an internal comparator that reproduces the order of Solr/the
  database.
* Add an integration test to verify that the sort order corresponds to
  the used comparator.

(cherry picked from commit 4a5e7b0)
michitux added a commit that referenced this pull request Nov 7, 2024
@michitux
XWIKI-22635: On restart, documents to re-index aren't correctly compu…
22f8781 
…ted (#3622)

* Use an internal comparator that reproduces the order of Solr/the
  database.
* Add an integration test to verify that the sort order corresponds to
  the used comparator.

(cherry picked from commit 4a5e7b0)
michitux added a commit that referenced this pull request Nov 7, 2024
@michitux
XWIKI-22635: On restart, documents to re-index aren't correctly compu…
290d450 
…ted (#3622)

* Use an internal comparator that reproduces the order of Solr/the
  database.
* Add an integration test to verify that the sort order corresponds to
  the used comparator.

(cherry picked from commit 4a5e7b0)
(cherry picked from commit 22f8781)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmortagne tmortagne tmortagne approved these changes

Assignees

@michitux michitux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michitux @tmortagne