XWIKI-12629: Page Right is shown when administering inexistent WebHome page #3603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e page * Fixed test that relied on an uncreated page's administration section
Sereza7
added
backport stable-15.10.x
surli
reviewed
Oct 25, 2024
| page = new AdministrablePage(); | ||
| AdministrationPage pageAdministrationPage = page.clickAdministerPage(); | ||
|
|
||
| assertEquals("Page Administration: NonExistentSpace", pageAdministrationPage.getDocumentTitle()); | ||
| assertEquals("Page Administration: AdministrationIT.verifyAdministrationSections", pageAdministrationPage.getDocumentTitle()); |
There was a problem hiding this comment.
This won't work if you execute the whole test suite as the test class will be NestedAdministrationIT. You need to use a serialization of the testReference.
There was a problem hiding this comment.
Addressed in 61c2675 . I tested with the singular test already, but I'm currently running the whole test suite. I'll update this if the whole test suite does not pass somehow.
…e page * Serialized the reference
tmortagne
reviewed
Oct 28, 2024
| page = new AdministrablePage(); | ||
| AdministrationPage pageAdministrationPage = page.clickAdministerPage(); | ||
|
|
||
| assertEquals("Page Administration: NonExistentSpace", pageAdministrationPage.getDocumentTitle()); | ||
| String fullName = setup.serializeReference(testReference.getParent()).split(":")[1]; |
There was a problem hiding this comment.
I think what you were searching for is TestUtils#serializeLocalReference (which does not contain the wiki part).
There was a problem hiding this comment.
Hmmm I didn't paid enough attention: that one is not available in 15.10.x / 16.4.x. Backporting it.
…me page * Serialize the local reference
github-actions bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
…e page (#3603) * Fixed test that relied on an uncreated page's administration section * Serialized the reference * Serialize the local reference --------- Co-authored-by: Simon Urli <[email protected]> (cherry picked from commit f3cfb75)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
…e page (#3603) * Fixed test that relied on an uncreated page's administration section * Serialized the reference * Serialize the local reference --------- Co-authored-by: Simon Urli <[email protected]> (cherry picked from commit f3cfb75)
surli
pushed a commit
that referenced
this pull request
Oct 28, 2024
…e page (#3603) * Fixed test that relied on an uncreated page's administration section * Serialized the reference * Serialize the local reference --------- Co-authored-by: Simon Urli <[email protected]> (cherry picked from commit f3cfb75)
surli
pushed a commit
that referenced
this pull request
Oct 28, 2024
…e page (#3603) * Fixed test that relied on an uncreated page's administration section * Serialized the reference * Serialize the local reference --------- Co-authored-by: Simon Urli <[email protected]> (cherry picked from commit f3cfb75)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-12629
Changes
Description
Clarifications
Screenshots & Video
None, test only change
Executed Tests
Successfully ran
mvn clean install -f xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-docker -PdockerExpected merging strategy
Similar to XWIKI-12629: Page Right is shown when administering inexistent WebHome page #3590