Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-21770: Mention administration radio buttons are not aligned #2819

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Jan 25, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-21770

Changes

Description

  • Separated style for checkbox and radio inputs
  • Updated vertical align for radio inputs

Clarifications

  • This also fixes a misalign in the rights UI.
  • The additionnal style does not seem to be needed for the radio buttons (vertical-align: baseline is the default), but this ensures that it doesn't get another value in an unexpected place.

Screenshots & Video

Before the changes in this PR vvv
21770-beforePR1
21770-beforePR2
After the changes in this PR vvv
21770-afterPR2
21770-afterPR1

Executed Tests

No executed tests, low impact style changes. Just manually checked that the changes were okay in a few sections of the admin UI.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • N/A

Sereza7 and others added 2 commits January 25, 2024 11:43
* Separated style for checkbox and radio inputs
* Updated vertical align for radio inputs

Note: This also fixes a misalign in the rights UI.
@surli surli added the conflicts To be used when there's conflicts needed to be solved in a PR. label Aug 27, 2024
@Sereza7 Sereza7 removed the conflicts To be used when there's conflicts needed to be solved in a PR. label Oct 10, 2024
@Sereza7 Sereza7 requested a review from surli October 24, 2024 08:37
@surli surli merged commit 8bfe406 into xwiki:master Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants