Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in xUnit1051 to account for arbitrary argument order #187

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

campersau
Copy link
Contributor

Argument order can not be trusted, always check if parameter matches argument parameter.

Fixes xunit/xunit#3011

@bradwilson bradwilson merged commit 3932a3e into xunit:main Aug 25, 2024
5 checks passed
@bradwilson
Copy link
Member

Thanks!

@campersau campersau deleted the xunit1051fix branch August 25, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xUnit1051 marks method with omitted optional parameters and named cancellationToken parameter
2 participants