-
-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DDG: allow using conversations and improve UX for incorrect usage #2210
base: main
Are you sure you want to change the base?
Conversation
The vqd-4 changes for each continuation of the converation, thus allowing stepping back or branching, but this contradicts the initial authors assumption. The logic is as such: first status update gives us first empty chat id, the successive chat queries send the new conversation id, we just got to read it and return the new one to the user.
|
||
vqd_4_new = response.headers.get("x-vqd-4") | ||
if vqd_4_new is not None: | ||
yield Conversation(vqd_4_new, messages) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I raise an exception if we could not get the conversation id, but the user requested it? Currently it's not a silent error, the user can detect an absence of the Converation chunk.
If i correclty remeber ddg site give 50 messages Converation and after need press "Fire" (clear button). |
Bumping this pull request because it has been open for 7 days with no activity. Closing automatically in 7 days unless it becomes active again. |
Thank you for these valuable improvements and the detailed explanation about vqd-4 behavior. Your changes significantly enhance error handling and conversation management. I appreciate your efforts in improving the |
DDG: ValueError: More than one message requires using conversation. This happening after first message sended or if some "bots" use conversation saving well we have error to |
Yes, otherwise you'll get an error I referenced in the ticket description. |
The vqd-4 changes for each continuation of the converation, thus allowing stepping back or branching, but this contradicts the initial authors assumption. The logic is as such: first status update gives us first empty chat id, the successive chat queries send the new conversation id, we just got to read it and return the new one to the user.
Before that I was getting this if I were to use a conversation (DDG does not allow more than one message without it):
Also it's better to make user track messages, rather than half-tracking present in here (does not track llm answer, so user have to add it to conversation messages for some reason ...) and AFAIC if a user wants to do anything useful with llm, they have to manage the messages history.