Make download bar generic #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terjanq
reviewed
Apr 21, 2024
| @@ -57,7 +57,7 @@ setTimeout(() => { | |||
| ``` | |||
|
|
|||
| {{< hint important >}} | |||
| This attack is only possible in Chromium-based browsers with automatic downloads enabled. In addition, the attack can't be repeated since the user needs to close the download bar for it to be measurable again. | |||
There was a problem hiding this comment.
Does it now also affect other browsers? E.g. Firefox?
|
I don't know what browsers it affects chrome moved where downloads are now.
And the concept of a download bar is something any browser could implement.
…On Sun, Apr 21, 2024, 8:38 PM terjanq ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In content/docs/attacks/navigations.md
<#159 (comment)>:
> @@ -57,7 +57,7 @@ setTimeout(() => {
```
{{< hint important >}}
-This attack is only possible in Chromium-based browsers with automatic downloads enabled. In addition, the attack can't be repeated since the user needs to close the download bar for it to be measurable again.
Does it now also affect other browsers? E.g. Firefox?
—
Reply to this email directly, view it on GitHub
<#159 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHQZ74N7DS7SJHAID6JEJUDY6QISBAVCNFSM6AAAAABGRAN2KGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMJTGUYDKNJXGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Then probably it's just better to move it off to a historical leaks section. I checked Edge, Firefox, and Chrome on my machine and neither of these changes the viewport. |
|
I'm back! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150