-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest updates #84
Open
achernet
wants to merge
15
commits into
xrmx:master
Choose a base branch
from
achernet:latest_updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Latest updates #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
When Python's bytes.decode() method encounters encounters a byte sequence that cannot be decoded, it will take an action dependent on its second argument: 'strict': raise UnicodeDecodeError exception (default) 'replace': insert U+FFFD 'ignore': skip to next character While most inputs appear to be sanitized, dmesg output is passed to _parse_dmesg() as is, and can contain data that escapes to invalid Unicode. When the parser attempts to decode this data it immediately raises an exception and dies, as seen in xrmx#77. To prevent this issue, I set the error handling method to 'replace', as 'ignore' can hide decoding errors from developers working with *really* broken dmesg logs. The parts of dmesg the parser looks at should be in a standard format anyway, so a U+FFFD (Replacement Character) or two after the timestamp shouldn't be too harmful.
Hello, With gnu make (4.1), I wasn't able to override `CC` value with `CROSS_COMPILE`. To find out what's really going on, I've added this temporary build target to dump variables ``` print-% : ; @echo $* = $($*) ``` Whenever I pass `CONFIG_CROSS_COMPILE` via environment, it was getting assigned to `CROSS_COMPILE` but `make` was not changing the default value of `CC` due to `?=` operator: ``` $ CONFIG_CROSS_COMPILE=arm-linux-gnueabihf- make print-CROSS_COMPILE print-CC CROSS_COMPILE = arm-linux-gnueabihf- CC = cc ``` So I've replaced the `?=` operator with `=`. _(This will prevent `CC=compiler make` definitions from working properly but that can be resolved by `CC=compiler make -e`, if needed.)_
…latest_updates
…nto latest_updates
…chart into latest_updates
…an/bootchart into latest_updates
Thanks for the PR, most of this stuff is not supposed to be merged upstream but some may be chery-picked |
Thanks Riccardo for continuing to fly the flag and review patches here ! =) good stuff. |
@achernet i think i've merged all the upstreamable ones, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I aggregated all the latest updates and merged them into this branch if you're inclined to review and merge it.