Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest updates #84

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Latest updates #84

wants to merge 15 commits into from

Conversation

achernet
Copy link

@achernet achernet commented Jul 3, 2020

I aggregated all the latest updates and merged them into this branch if you're inclined to review and merge it.

SvenDowideit and others added 15 commits September 22, 2017 12:48
Signed-off-by: Sven Dowideit <[email protected]>
When Python's bytes.decode() method encounters encounters a byte sequence
that cannot be decoded, it will take an action dependent on its second argument:
'strict': raise UnicodeDecodeError exception (default)
'replace': insert U+FFFD
'ignore': skip to next character

While most inputs appear to be sanitized, dmesg output is passed to
_parse_dmesg() as is, and can contain data that escapes to invalid Unicode.
When the parser attempts to decode this data it immediately raises an exception
and dies, as seen in xrmx#77.

To prevent this issue, I set the error handling method to 'replace', as 'ignore' can
hide decoding errors from developers working with *really* broken dmesg logs.
The parts of dmesg the parser looks at should be in a standard format anyway,
so a U+FFFD (Replacement Character) or two after the timestamp shouldn't be
too harmful.
Hello,

With gnu make (4.1), I wasn't able to override `CC` value with `CROSS_COMPILE`.
To find out what's really going on, I've added this temporary build target to dump variables

```
print-%  : ; @echo $* = $($*)
```
Whenever I pass `CONFIG_CROSS_COMPILE` via environment, it was getting assigned to `CROSS_COMPILE` but `make` was not changing the default value of `CC` due to `?=` operator:

```
$ CONFIG_CROSS_COMPILE=arm-linux-gnueabihf- make print-CROSS_COMPILE print-CC
CROSS_COMPILE = arm-linux-gnueabihf-
CC = cc
```

So I've replaced the `?=` operator with `=`. _(This will prevent `CC=compiler make` definitions from working properly but  that can be resolved by `CC=compiler make -e`, if needed.)_
@xrmx
Copy link
Owner

xrmx commented Jul 4, 2020

Thanks for the PR, most of this stuff is not supposed to be merged upstream but some may be chery-picked

@mmeeks
Copy link
Collaborator

mmeeks commented Jul 9, 2020

Thanks Riccardo for continuing to fly the flag and review patches here ! =) good stuff.

@xrmx
Copy link
Owner

xrmx commented Aug 9, 2020

@achernet i think i've merged all the upstreamable ones, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants