Demo broken shareable configs #83
Conversation
|
Cool. Thanks for doing this. Could you make it something I could merge? So that tests can just fail until it's fixed. |
|
You mean to |
| @@ -94,5 +94,8 @@ | |||
| "ignores": [ | |||
| "cli.js" | |||
| ] | |||
| }, | |||
| "ava": { | |||
| "files": "test/cli.js" | |||
vadimdemedes
force-pushed
the
broken-configs
branch
from
55f7056
to
fcb3374
Compare
|
Done! |
| @@ -31,3 +31,9 @@ test.skip('ignores fixture', async t => { | |||
| const cwd = path.join(__dirname, 'fixtures/ignores'); | |||
| t.throws(execa('../../../cli.js', ['--no-local'], {cwd})); | |||
| }); | |||
|
|
|||
| test('supports shareable config', async () => { | |||
| await execa('rm', ['-rf', '../node_modules/xo'], {cwd: __dirname}); | |||
There was a problem hiding this comment.
Sorry, didn't notice this. Why is this needed?
There was a problem hiding this comment.
Oh yes, I guess this is another, separate issue. https://github.com/sindresorhus/xo/blob/master/package.json#L91 causes cli.js to stop execution and rely on node_modules/xo rather than version in master branch. So when you're testing cli.js, you are not actually testing it, because it spawns cli.js from node_modules/xo.
There was a problem hiding this comment.
Hmm, that's what the --no-local flag is supposed to prevent, though.
There was a problem hiding this comment.
Done ;) Totally my overshit oversight.
vadimdemedes
force-pushed
the
broken-configs
branch
from
fcb3374
to
cc79ed2
Compare
Demo broken shareable configs
PR to demonstrate #71 (comment). The test project is in
test/fixtures/project.