Removing legacy build system #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaviergmail
requested changes
Jan 30, 2023
| @@ -7,7 +7,6 @@ __pycache__/ | |||
| *.so | |||
|
|
|||
| # Distribution / packaging | |||
| Pipfile.lock | |||
There was a problem hiding this comment.
We generally don't want to include Pipfile.lock for libraries because that ties us into dependencies for a specific Python version and potential contributors might not have the same version as us, potentially creating issues for them (and likely making most PRs play a game of cat-and-mouse game of different people re-locking on different versions)
There was a problem hiding this comment.
Generally don't want to include lock files in gitignore? Or don't want to include them in git?
There was a problem hiding this comment.
Sorry, I see how that was ambiguous. We don't want to include it in version control for projects that aren't pinned to a specific Python version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.