fix(endpoint): fix endpoint.SecurityString

xoctopus · Jul 9, 2024 · 3c843a1 · 3c843a1
1 parent 124e197
commit 3c843a1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/endpoint.go b/endpoint.go
@@ -8,7 +8,7 @@ import (
 	"strconv"
 	"strings"
 
-	"github.com/pkg/errors"
+	"github.com/xoctopus/x/misc/must"
 	"github.com/xoctopus/x/reflectx"
 	"github.com/xoctopus/x/textx"
 )
@@ -45,14 +45,14 @@ func (e Endpoint) String() string {
 	}
 
 	s, err := url.QueryUnescape(u.String())
-	if err != nil {
-		panic(errors.Wrapf(err, "failed to query unescape: %s", u.String()))
-	}
+	must.NoErrorWrap(err, "failed to query unescape: %s", u.String())
 	return s
 }
 
 func (e Endpoint) SecurityString() string {
-	e.Password = Password(e.Password.SecurityString())
+	if e.Password != "" {
+		e.Password = Password(e.Password.SecurityString())
+	}
 	return e.String()
 }
 

diff --git a/endpoint_test.go b/endpoint_test.go
@@ -91,6 +91,7 @@ func TestEndpoint(t *testing.T) {
 
 	t.Run("SecurityString", func(t *testing.T) {
 		t.Log(cases["Postgres"].ep.SecurityString())
+		t.Log(cases["STMPs"].ep.SecurityString())
 	})
 
 	t.Run("IsZero", func(t *testing.T) {