Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix module scanning #5686

Merged
merged 21 commits into from
Oct 8, 2024
Merged

Fix module scanning #5686

merged 21 commits into from
Oct 8, 2024

Conversation

Arthapz
Copy link
Member

@Arthapz Arthapz commented Oct 4, 2024

it solve #5425

@Arthapz Arthapz marked this pull request as draft October 4, 2024 16:02
@Arthapz Arthapz mentioned this pull request Oct 4, 2024
Closed
@Arthapz Arthapz marked this pull request as ready for review October 4, 2024 17:32
@waruqi waruqi added this to the v2.9.6 milestone Oct 5, 2024
@waruqi
Copy link
Member

waruqi commented Oct 8, 2024

@Arthapz Did you rebase to dev first? it need newest hashset implementaion.

@waruqi waruqi mentioned this pull request Oct 8, 2024
Closed
@Arthapz
Copy link
Member Author

Arthapz commented Oct 8, 2024

@Arthapz Did you rebase to dev first? it need newest hashset implementaion.

i didn't rebased ton dev, was waiting for ur other PR to g et merged

@Arthapz
Copy link
Member Author

Arthapz commented Oct 8, 2024

it is rebased now

@waruqi waruqi merged commit aed4aaf into xmake-io:dev Oct 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waruqi waruqi waruqi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.9.6
Development

Successfully merging this pull request may close these issues.
2 participants
@Arthapz @waruqi