fix "as_needed" flag order #5631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
Sep 18, 2024
| @@ -370,8 +370,8 @@ function nf_linkgroup(self, linkgroup, opt) | |||
| end | |||
| if as_needed then | |||
There was a problem hiding this comment.
为啥启用 as_needed , 反而是 "-Wl,--no-as-needed flags -Wl,--as-needed"? 怪怪的
There was a problem hiding this comment.
因为默认就是 as_needed (只链接实际需要的)
而--no-as-needed 才是全部链接
There was a problem hiding this comment.
或许改下option的名字？ as_needed -> no_as_needed
waruqi
reviewed
Sep 18, 2024
xmake/modules/core/tools/gcc.lua
Outdated
| @@ -368,10 +368,10 @@ function nf_linkgroup(self, linkgroup, opt) | |||
| table.insert(prefix_flags, "-Wl,-Bstatic") | |||
| table.insert(suffix_flags, 1, "-Wl,-Bdynamic") | |||
| end | |||
| if as_needed then | |||
| if not as_needed then | |||
There was a problem hiding this comment.
不能这么判断，没设置 as_needed ，就是 nil，不得一样被设置。。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix "as_needed" flag order