Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: curp client propose #975

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented Sep 2, 2024

This PR includes several changes:

  • Moves client propose code to a seperate module propose_impl
  • Improve propose latency for mutative commands
    This is done by simultaneously waitting for the record request to the cluster and the message from the leader gRPC stream.

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@bsbds bsbds force-pushed the refactor-propose branch 4 times, most recently from 845abc1 to d49dd01 Compare September 2, 2024 04:13
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 83.12236% with 40 lines in your changes missing coverage. Please review.

Project coverage is 75.23%. Comparing base (e35b35a) to head (7cfccb6).
Report is 314 commits behind head on master.

Files with missing lines Patch % Lines
crates/curp/src/client/unary/propose_impl.rs 83.33% 24 Missing and 13 partials ⚠️
crates/curp/src/client/tests.rs 0.00% 2 Missing ⚠️
crates/curp/src/client/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #975      +/-   ##
==========================================
- Coverage   75.55%   75.23%   -0.33%     
==========================================
  Files         180      190      +10     
  Lines       26938    28479    +1541     
  Branches    26938    28479    +1541     
==========================================
+ Hits        20353    21426    +1073     
- Misses       5366     5756     +390     
- Partials     1219     1297      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsbds bsbds marked this pull request as ready for review September 2, 2024 04:25
@mergify mergify bot requested a review from a team September 2, 2024 04:25
@mergify mergify bot requested a review from a team September 23, 2024 01:05
Copy link

mergify bot commented Sep 23, 2024

@bsbds Your PR is in conflict and cannot be merged.

Copy link

mergify bot commented Sep 23, 2024

@bsbds Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft September 23, 2024 02:49
@mergify mergify bot added the CI:fail CI has failed label Sep 23, 2024
@mergify mergify bot marked this pull request as ready for review September 23, 2024 03:09
@mergify mergify bot removed the CI:fail CI has failed label Sep 23, 2024
@mergify mergify bot requested a review from a team September 23, 2024 03:14
@bsbds bsbds merged commit aa3b568 into xline-kv:master Oct 9, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants