refactor: add auto reconnect to curp client #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bsbds <[email protected]>
* Removes unecessary async * Panics when url is ill-formed instead of returning an error Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
The lock test uses time to sync two tokio tasks, which may cause problem becuase client propose may takes indefinite time. This commit refactor it to use a `Event` for sync instead. Signed-off-by: bsbds <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #972 +/- ##
==========================================
- Coverage 75.55% 75.20% -0.35%
==========================================
Files 180 190 +10
Lines 26938 28426 +1488
Branches 26938 28426 +1488
==========================================
+ Hits 20353 21379 +1026
- Misses 5366 5747 +381
- Partials 1219 1300 +81 ☔ View full report in Codecov by Sentry. |
| /// Connect to a server | ||
| async fn connect_to<Client: FromTonicChannel>( | ||
| /// Creates a new connection | ||
| fn connect_to<Client: FromTonicChannel>( |
There was a problem hiding this comment.
Why do you change this method from async to sync?
There was a problem hiding this comment.
The change_tx.send is in a synchronous context, where a try_send should never blocks. Therefore it is unecessary to use async here.
| .await | ||
| .into_iter() | ||
| .collect::<Result<Vec<_>, _>>() | ||
| /// Creates a new connection with auto reconnect |
There was a problem hiding this comment.
In what situation we need such a reconnect mechanism?
There was a problem hiding this comment.
Please refer to: hyperium/tonic#1254.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two major changes:
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)