fix: task manager panic in some cases #925
Conversation
|
@lxl66566 Convert your pr to draft since CI failed |
lxl66566
force-pushed
the
panic-fix
branch
2 times, most recently
from
7418d9f
to
7c29d0a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #925 +/- ##
==========================================
- Coverage 75.55% 75.18% -0.37%
==========================================
Files 180 190 +10
Lines 26938 28492 +1554
Branches 26938 28492 +1554
==========================================
+ Hits 20353 21422 +1069
- Misses 5366 5764 +398
- Partials 1219 1306 +87 ☔ View full report in Codecov by Sentry. |
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 14 days |
|
@lxl66566 Your PR is in conflict and cannot be merged. |
|
@lxl66566 Convert your pr to draft since CI failed |
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 14 days |
Signed-off-by: lxl66566 <[email protected]> chore: add more docs Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
| .iter() | ||
| .filter_map(|task| (task.depend_cnt == 0).then_some(task.name)) | ||
| .collect() | ||
| .collect(); | ||
| if !tasks.is_empty() { |
There was a problem hiding this comment.
Use assert_eq!(tasks.is_empty(), root_tasks.is_empty()) ?
Depends-On: #918
fix #919