chore: code fixing, remove redundant and add missing #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #880 +/- ##
==========================================
- Coverage 75.55% 75.21% -0.35%
==========================================
Files 180 190 +10
Lines 26938 28480 +1542
Branches 26938 28480 +1542
==========================================
+ Hits 20353 21420 +1067
- Misses 5366 5761 +395
- Partials 1219 1299 +80 ☔ View full report in Codecov by Sentry. |
|
@bsbds Please take at a look. |
|
rebased. and proto has been updated in #903 . |
|
@lxl66566 Convert your pr to draft since CI failed |
|
@lxl66566 Convert your pr to draft since CI failed |
lxl66566
force-pushed
the
code-fix
branch
3 times, most recently
from
15b13bf
to
67ba153
Compare
|
@lxl66566 Convert your pr to draft since CI failed |
|
@lxl66566 Your PR is in conflict and cannot be merged. |
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 14 days |
|
@lxl66566 Convert your pr to draft since CI failed |
Signed-off-by: lxl66566 <[email protected]> chore(curp): add a missing testcase to lib.rs Signed-off-by: lxl66566 <[email protected]> chore(raw_curp): trivial change to functional expression Signed-off-by: lxl66566 <[email protected]>
bsbds
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
.fieldinKvClientandLeaseClientwhat changes does this pull request make?
.fieldinKvClientandLeaseClientquorum_should_work()test, corresponding to the above node(10).raw_curp/log.rsare there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)