Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: move token authentication to the network layer #648

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

themanforfree
Copy link
Collaborator

@themanforfree themanforfree commented Feb 6, 2024

Please briefly answer these questions:
based on #645

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    move token authentication to the network layer
  • what changes does this pull request make?
    move token authentication to the network layer
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    no

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 99 lines in your changes are missing coverage. Please review.

Comparison is base (f74fbda) 74.50% compared to head (be490b9) 74.38%.
Report is 1 commits behind head on master.

Files Patch % Lines
crates/xline/src/server/kv_server.rs 31.70% 23 Missing and 5 partials ⚠️
crates/xline/src/server/lock_server.rs 8.00% 23 Missing ⚠️
crates/xline/src/storage/auth_store/store.rs 86.90% 11 Missing ⚠️
crates/curp/src/client/tests.rs 91.48% 8 Missing ⚠️
crates/xline-client/src/clients/kv.rs 81.48% 0 Missing and 5 partials ⚠️
crates/xline/src/storage/compact/mod.rs 0.00% 4 Missing ⚠️
crates/curp/src/rpc/connect.rs 57.14% 1 Missing and 2 partials ⚠️
crates/xline-client/src/clients/auth.rs 71.42% 0 Missing and 2 partials ⚠️
crates/xline-client/src/clients/lease.rs 83.33% 0 Missing and 2 partials ⚠️
crates/xline/src/server/auth_server.rs 75.00% 1 Missing and 1 partial ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
- Coverage   74.50%   74.38%   -0.12%     
==========================================
  Files         170      170              
  Lines       24827    24834       +7     
  Branches    24827    24834       +7     
==========================================
- Hits        18497    18474      -23     
- Misses       5188     5220      +32     
+ Partials     1142     1140       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themanforfree themanforfree merged commit 6779d42 into xline-kv:master Feb 26, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants