-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: move token authentication to the network layer #648
Merged
themanforfree
merged 1 commit into
xline-kv:master
from
themanforfree:feat/move-token-auth
Feb 26, 2024
Merged
[feat]: move token authentication to the network layer #648
themanforfree
merged 1 commit into
xline-kv:master
from
themanforfree:feat/move-token-auth
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
==========================================
- Coverage 74.50% 74.38% -0.12%
==========================================
Files 170 170
Lines 24827 24834 +7
Branches 24827 24834 +7
==========================================
- Hits 18497 18474 -23
- Misses 5188 5220 +32
+ Partials 1142 1140 -2 ☔ View full report in Codecov by Sentry. |
themanforfree
force-pushed
the
feat/move-token-auth
branch
2 times, most recently
from
February 19, 2024 01:17
3eb7a47
to
3cfab3e
Compare
iGxnon
reviewed
Feb 21, 2024
Signed-off-by: themanforfree <[email protected]>
themanforfree
force-pushed
the
feat/move-token-auth
branch
from
February 22, 2024 02:11
3cfab3e
to
be490b9
Compare
iGxnon
approved these changes
Feb 26, 2024
Phoenix500526
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
based on #645
move token authentication to the network layer
move token authentication to the network layer
no