Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: read state barrier #503

Closed
wants to merge 4 commits into from
Closed

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented Nov 3, 2023

Fix 1 and 2 in #497

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@bsbds bsbds force-pushed the readstate-add-ucp branch 2 times, most recently from 9137685 to bcb2aca Compare November 3, 2023 07:27
@xline-kv xline-kv deleted a comment from codecov bot Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (974c3a9) 54.18% compared to head (ccbe667) 54.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
+ Coverage   54.18%   54.24%   +0.06%     
==========================================
  Files         101      101              
  Lines       18239    18271      +32     
  Branches    18239    18271      +32     
==========================================
+ Hits         9883     9912      +29     
- Misses       7767     7770       +3     
  Partials      589      589              
Files Coverage Δ
...urp/src/server/cmd_worker/conflict_checked_mpmc.rs 84.49% <100.00%> (ø)
curp/src/server/curp_node.rs 30.02% <0.00%> (ø)
xline/src/server/barriers.rs 92.85% <97.22%> (+15.68%) ⬆️
curp/src/server/raw_curp/mod.rs 66.51% <0.00%> (-0.73%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: bsbds <[email protected]>
@bsbds bsbds marked this pull request as ready for review November 7, 2023 01:50
@iGxnon
Copy link
Contributor

iGxnon commented Nov 7, 2023

A bit vec queue might be sufficient to solve this gracefully.

Screenshot 2023-11-07 at 14 30 46

Based on your description, I found that the Tracker in #450 may be able to meet this requirement. It has a higher memory compression ratio and better complexity than a binary heap.

@bsbds
Copy link
Collaborator Author

bsbds commented Nov 22, 2023

A bit vec queue might be sufficient to solve this gracefully.

Screenshot 2023-11-07 at 14 30 46 Based on your description, I found that the [Tracker](https://github.com//pull/450/files#diff-d16e0732694070d1f04f3160ccafa6b615b4cfd085837a472c1d3e13fe4ceb34) in #450 may be able to meet this requirement. It has a higher memory compression ratio and better complexity than a binary heap.

Yeah I can rebase this on #450

@bsbds bsbds marked this pull request as draft November 22, 2023 00:57
@bsbds
Copy link
Collaborator Author

bsbds commented Jan 4, 2024

After refactoring this PR is no longer needed

@bsbds bsbds closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants