Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: txn command key #472

Merged
merged 4 commits into from
Dec 1, 2023
Merged

fix: txn command key #472

merged 4 commits into from
Dec 1, 2023

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented Oct 8, 2023

Closes: #470

Based on: #469

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (c8aa843) 63.34% compared to head (189478e) 63.58%.

Files Patch % Lines
xline/src/server/lease_server.rs 0.00% 11 Missing ⚠️
xlineapi/src/command.rs 88.29% 11 Missing ⚠️
xline-client/src/clients/kv.rs 40.00% 3 Missing ⚠️
xline-client/src/clients/lease.rs 0.00% 2 Missing ⚠️
xline-client/src/clients/auth.rs 0.00% 1 Missing ⚠️
xline-client/src/clients/lock.rs 0.00% 1 Missing ⚠️
xline/src/server/auth_server.rs 50.00% 1 Missing ⚠️
xline/src/server/kv_server.rs 66.66% 1 Missing ⚠️
xline/src/server/lock_server.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
+ Coverage   63.34%   63.58%   +0.23%     
==========================================
  Files         102      102              
  Lines       18540    18585      +45     
  Branches    18540    18585      +45     
==========================================
+ Hits        11745    11818      +73     
+ Misses       6065     6034      -31     
- Partials      730      733       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsbds bsbds marked this pull request as ready for review October 8, 2023 04:14
@bsbds bsbds marked this pull request as draft November 1, 2023 11:23
@bsbds bsbds force-pushed the fix-txn-key branch 2 times, most recently from 7ff3ef8 to f986db1 Compare November 3, 2023 06:42
@bsbds bsbds marked this pull request as ready for review November 3, 2023 06:45
@Phoenix500526 Phoenix500526 added this to the v0.6.1 milestone Nov 22, 2023
@bsbds bsbds force-pushed the fix-txn-key branch 3 times, most recently from aea95df to 4c21fd3 Compare November 24, 2023 06:23
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@iGxnon iGxnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Phoenix500526 Phoenix500526 added this pull request to the merge queue Dec 1, 2023
Merged via the queue into xline-kv:master with commit b61ea9e Dec 1, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Txn child request keys get ignored during conflict check
3 participants